Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74489
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.128.179 cause and error)
MIME-Version: 1.0
In-Reply-To: <962B3020-200F-45D2-8FEC-AD7A0BFDA50E@ajf.me>
References: <CA+9eiLuknJ7am5jU4WBN7fGXUcZtbb6axsji8ZnydCJ4P-O9hw@mail.gmail.com>
	<CABBJUpcNL67-cXyBd=yuWdhZPmHM592Q4-g2PGcyOTS_KsBaqQ@mail.gmail.com>
	<CA+9eiLvj5GVNQ=1D2=RbenfUCUAPaG3uP5H+yAW=TKd-jEVyjw@mail.gmail.com>
	<-6285448086228171932@unknownmsgid>
	<CA+9eiLvUeu0j+sPz-EWeq4VC=Spzc7tseAp4VHqpiFEaxHdLiQ@mail.gmail.com>
	<67d97efff27b61e45ef74d4f4339b4b3@mail.gmail.com>
	<962B3020-200F-45D2-8FEC-AD7A0BFDA50E@ajf.me>
Date: Mon, 26 May 2014 12:43:06 +0400
Message-ID: <CA+9eiLu7CZwEFS0bRHCdW2+ScnfuCbo+FCT-8HymLm=WZBhfhA@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Zeev Suraski <zeev@zend.com>, Xinchen Hui <xinchen.h@zend.com>, 
	PHP Internals <internals@lists.php.net>, Bob Weinand <bobwei9@hotmail.com>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, Andi Gutmans <andi@zend.com>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=089e01183d0a7051d804fa499147
Subject: Re: [PHP-DEV] RE: [RFC] Fast Parameter Parsing API
From: dmitry@zend.com (Dmitry Stogov)

--089e01183d0a7051d804fa499147
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I more or less like the last option, and actually it's similar to Bob
original proposal.
But I see two disadvantages:
1) It'll relay on macros with variable arguments and it may be not portable
across all compilers.
2) It uses nested macros and it may make a nightmare for finding source of
some syntax mistake in user code.

Thanks. Dmitry.


On Mon, May 26, 2014 at 12:24 PM, Andrea Faulds <ajf@ajf.me> wrote:

>
> On 26 May 2014, at 08:17, Zeev Suraski <zeev@zend.com> wrote:
>
> > I think the main challenge is the fact it turns what today is a one-lin=
er
> > (albeit a bit obscure) into a long multi-line all-caps gig.   I=E2=80=
=99ve tried
> to
> > think about alternatives but so far came short with something that
> > elegantly solves the problem, short of using C++ which I think goes too
> far
> > in the context of what we=E2=80=99re trying to achieve.
>
> Perhaps it could be simplified? Something like this:
>
> ZEND_PARSE_PARAMETERS(Z_PARAM_ARRAY, input, Z_PARAM_LONG, offset,
> Z_PARAM_OPTIONAL, Z_PARAM_ZVAL, z_length, Z_PARAM_BOOL, preserve_keys);
>
> That=E2=80=99s still rather unwieldy, though. Maybe Z_PARAM could be shor=
tened to
> ZP_? Then we=E2=80=99d have this:
>
> ZEND_PARSE_PARAMETERS(ZP_ARRAY, input, ZP_LONG, offset, ZP_OPTIONAL,
> ZP_ZVAL, z_length, ZP_BOOL, preserve_keys)
>
> That=E2=80=99s not so bad, right? That would be parsing at runtime instea=
d of with
> macros, though. Maybe this?
>
> ZEND_PARSE_PARAMETERS(ZP_ARRAY(input), ZP_LONG(offset), ZP_OPTIONAL,
> ZP_ZVAL(z_length), ZP_BOOL(preserve_keys))
>
> Except, at least if we=E2=80=99re only using C89, we can=E2=80=99t use a =
nice
> function-like macro syntax here. You=E2=80=99d also still need to explici=
tly state
> numbers of arguments. The first and second proposals are nice because the=
y
> requires none of this due to runtime parsing, but it would be no faster
> than zend_parse_parameters.
>
> Does anyone have a good idea?
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>

--089e01183d0a7051d804fa499147--