Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74478
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.220.177 cause and error)
References: <CA+9eiLuknJ7am5jU4WBN7fGXUcZtbb6axsji8ZnydCJ4P-O9hw@mail.gmail.com>
 <CABBJUpcNL67-cXyBd=yuWdhZPmHM592Q4-g2PGcyOTS_KsBaqQ@mail.gmail.com> <CA+9eiLvj5GVNQ=1D2=RbenfUCUAPaG3uP5H+yAW=TKd-jEVyjw@mail.gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CA+9eiLvj5GVNQ=1D2=RbenfUCUAPaG3uP5H+yAW=TKd-jEVyjw@mail.gmail.com>
Date: Mon, 26 May 2014 10:01:16 +0300
Message-ID: <-6285448086228171932@unknownmsgid>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Xinchen Hui <xinchen.h@zend.com>, PHP Internals <internals@lists.php.net>, 
	Bob Weinand <bobwei9@hotmail.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Andi Gutmans <andi@zend.com>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=047d7bacc3aa38651c04fa4825be
Subject: Re: [RFC] Fast Parameter Parsing API
From: zeev@zend.com (Zeev Suraski)

--047d7bacc3aa38651c04fa4825be
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

To be perfectly honest, I tend to agree that the readability issues with
this proposal make it a bit difficult to digest.  And I'm not taking a 2.5%
real world performance gain lightly - it's huge.

I think we need to consider other alternatives as code readability and
maintainability are important factors to consider, not just performance...

Zeev

On 26 =D7=91=D7=9E=D7=90=D7=99 2014, at 08:39, Dmitry Stogov <dmitry@zend.c=
om> wrote:

I would be glad to see proposals from Hannes and Johannes, but we also need
to move phpng forward, and I wouldn't like to spend on this too much time.

Our proposal is mainly about speed (as well as the main phpng goal).
We identified yet another bottleneck and eliminated it.
Changes in readability and compile-time type checking are side effects of
implementation.

Thanks. Dmitry.


On Sat, May 24, 2014 at 4:50 PM, Xinchen Hui <xinchen.h@zend.com> wrote:

> Hey:
>
>
> On Fri, May 23, 2014 at 7:36 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> > Please take a look at https://wiki.php.net/rfc/fast_zpp
>
>
>      It's really a great improvement.
>
>      zend_parse_parameters is too heavy,  and to me:
>
>      Z_PARAM_STR()  is obviously readable than
> zend_parse_parameter("s" /* what the hell s means here? */,)
>
>      and the performance gain is also very significant ..
>
>      actually, I thought about somethings like that.. but this patch
> is better...
>
>      and these new APIs didn't break any APIS,   just provides a more
> fast choice...
>
>      I really don't understand why you guys think it not good?
>
>
>
> thanks
> >
> > Thanks. Dmitry.
>
>
>
> --
> Xinchen Hui  Laruence
> Consultant    at   Zend
> http://www.laruence.com/
>

--047d7bacc3aa38651c04fa4825be--