Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74473
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.174 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CA+9eiLuknJ7am5jU4WBN7fGXUcZtbb6axsji8ZnydCJ4P-O9hw@mail.gmail.com>
References: <CA+9eiLuknJ7am5jU4WBN7fGXUcZtbb6axsji8ZnydCJ4P-O9hw@mail.gmail.com>
Date: Sat, 24 May 2014 20:50:31 +0800
Message-ID: <CABBJUpcNL67-cXyBd=yuWdhZPmHM592Q4-g2PGcyOTS_KsBaqQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP Internals <internals@lists.php.net>, Bob Weinand <bobwei9@hotmail.com>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, Zeev Suraski <zeev@zend.com>, Andi Gutmans <andi@zend.com>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [RFC] Fast Parameter Parsing API
From: xinchen.h@zend.com (Xinchen Hui)

Hey:


On Fri, May 23, 2014 at 7:36 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Please take a look at https://wiki.php.net/rfc/fast_zpp


     It's really a great improvement.

     zend_parse_parameters is too heavy,  and to me:

     Z_PARAM_STR()  is obviously readable than
zend_parse_parameter("s" /* what the hell s means here? */,)

     and the performance gain is also very significant ..

     actually, I thought about somethings like that.. but this patch
is better...

     and these new APIs didn't break any APIS,   just provides a more
fast choice...

     I really don't understand why you guys think it not good?



thanks
>
> Thanks. Dmitry.



-- 
Xinchen Hui  Laruence
Consultant    at   Zend
http://www.laruence.com/