Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74469
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.176 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <537EE0A5.9030109@sugarcrm.com>
References: <2DC459EE-AE98-4CAE-977A-6FB918FDEF54@bafford.com>
	<537EA42B.4000000@lerdorf.com>
	<B20CF9D3-B61C-462E-825A-DA421F351694@bafford.com>
	<537EE0A5.9030109@sugarcrm.com>
Date: Fri, 23 May 2014 19:48:14 +0100
Message-ID: <CAEKnhAHrXO8qAJqhZCfoXZYB68oRTAZRW_BRo-ig_Ub_5gu0yQ@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: John Bafford <john@bafford.com>, Rasmus Lerdorf <rasmus@lerdorf.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11393a8c13af7804fa15ac87
Subject: Re: [PHP-DEV] Bison 3 support for PHP 5.5
From: bukka@php.net (Jakub Zelenka)

--001a11393a8c13af7804fa15ac87
Content-Type: text/plain; charset=UTF-8

On Fri, May 23, 2014 at 6:46 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> > So instead, I created the TSRMLS_DN and TSRMLS_CN macros which, in
> > the ZTS case, work like TSRMLS_D/TSRMLS_C, but when ZTS is off, still
> > resolve to a parameter (that must always be present), which is passed
> > NULL.
>
> I don't think it is a very good idea to add extra parameter that does
> nothing to every function. There should be a better solution to this.
>
>
I agree with Stas that the way how it's done at the moment is pretty ugly.

I was dealing with similar problem in jsond parser (
https://github.com/bukka/php-jsond/blob/master/jsond_parser.y ) where I
decided to use a structure (php_json_parser) for general parser info as
well as scanner data and TSRMLS if ZTS defined. It means that data from the
scanner are passed to the parser through that structure instead of using
global variable (that's the way how it's done in PHP). tsrm_ls can be set
using TSRMLS_SET_CTX fetched from that structure TSRMLS_FETCH_FROM_CTX.

So to sum it up... I think that a better solution would be using a
structure that would contain scanner data (_zend_php_scanner_globals ) and
TSRMLS if ZTS defined. It would be a cleaner solution IMHO. It could also
allow some optimization for the compiler as local variables might be saved
in registers (not sure about this one... :) ).

However this is probaly more something for phpng as it requires a bit more
changes... :)

Jakub

--001a11393a8c13af7804fa15ac87--