Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74443 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55009 invoked from network); 23 May 2014 08:42:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 May 2014 08:42:07 -0000 Authentication-Results: pb1.pair.com header.from=john@bafford.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=john@bafford.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain bafford.com from 96.241.205.2 cause and error) X-PHP-List-Original-Sender: john@bafford.com X-Host-Fingerprint: 96.241.205.2 nova.zort.net Received: from [96.241.205.2] ([96.241.205.2:58798] helo=nova.zort.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BB/9B-63132-DD90F735 for ; Fri, 23 May 2014 04:42:05 -0400 Received: from [IPv6:::1] (nova.zort.net [96.241.205.2]) (authenticated bits=0) by nova.zort.net (8.14.5/8.14.5) with ESMTP id s4N8g0Z4007134 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 23 May 2014 04:42:01 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) In-Reply-To: <537EE0A5.9030109@sugarcrm.com> Date: Fri, 23 May 2014 03:42:00 -0500 Cc: Rasmus Lerdorf , "internals@lists.php.net" Content-Transfer-Encoding: quoted-printable Message-ID: <486EF545-D0CE-4400-94B6-1D60259C2987@bafford.com> References: <2DC459EE-AE98-4CAE-977A-6FB918FDEF54@bafford.com> <537EA42B.4000000@lerdorf.com> <537EE0A5.9030109@sugarcrm.com> To: Stas Malyshev X-Mailer: Apple Mail (2.1878.2) Subject: Re: [PHP-DEV] Bison 3 support for PHP 5.5 From: john@bafford.com (John Bafford) Hi Stas, On May 23, 2014, at 00:46, Stas Malyshev wrote: > Hi! >=20 >> So instead, I created the TSRMLS_DN and TSRMLS_CN macros which, in >> the ZTS case, work like TSRMLS_D/TSRMLS_C, but when ZTS is off, still >> resolve to a parameter (that must always be present), which is passed >> NULL. >=20 > I don't think it is a very good idea to add extra parameter that does > nothing to every function. There should be a better solution to this. I agree it would be ideal to not have to include the extra parameter in = non-ZTS builds. However, it is only a few functions (zenderror, zendlex, = zendparse, init_error, ini_parse, ini_lex) that gain the extra = parameter. Those functions should not be frequently called, and when = they are, a NULL (or actual local parameter TSRMLS) is passed, so the = overhead should be pretty minimal. > --=20 > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 -John