Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74438
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain bafford.com from 96.241.205.2 cause and error)
Content-Type: multipart/signed; boundary="Apple-Mail=_6D1DD741-C43A-44F5-8329-FBA9DBBCBA5B"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\))
In-Reply-To: <537EA42B.4000000@lerdorf.com>
Date: Thu, 22 May 2014 20:44:29 -0500
Cc: internals@lists.php.net
Message-ID: <B20CF9D3-B61C-462E-825A-DA421F351694@bafford.com>
References: <2DC459EE-AE98-4CAE-977A-6FB918FDEF54@bafford.com> <537EA42B.4000000@lerdorf.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Subject: Re: [PHP-DEV] Bison 3 support for PHP 5.5
From: john@bafford.com (John Bafford)

--Apple-Mail=_6D1DD741-C43A-44F5-8329-FBA9DBBCBA5B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252

Hi Rasmus,

On May 22, 2014, at 20:28, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> On 5/22/14, 6:01 PM, John Bafford wrote:
>> Hi,
>>=20
>> I=92ve submitted a PR (https://github.com/php/php-src/pull/683) to =
add support for Bison 3.0 to PHP 5.5.
>>=20
>> I=92ve run the tests on this patch, with no unexpected errors, with =
Bison 2.4 (minimum version for PHP 5.5 and 5.6), 2.7, and 3.0, with and =
without --enable-maintainer-zts against the current PHP-5.5 and (with =
minor changes) master branches.
>=20
> Could you explain your changes a bit? You removed %pure-parser, for
> example, and you shuffled globals around. This looks like more than =
just
> adding support for Bison 3.
>=20
> -Rasmus

I replaced %pure-parser (which was deprecated) with %pure_parser (its =
replacement). (Also, YYERROR_VERBOSE, which also was deprecated, with =
%error-verbose.)

Most of the changes in the PR revolve around this change in =
Zend/zend_language_parser.y:
-%code requires {
-#ifdef ZTS
-# define YYPARSE_PARAM tsrm_ls
-# define YYLEX_PARAM tsrm_ls
-#endif
-}
+%parse-param { void *tsrm_ls }
+%lex-param { void *tsrm_ls }

YYPARSE_PARAM and YYLEX_PARAM were deprecated, and then removed, and =
replaced with %parse-param and %lex-param. However, you cannot (or I did =
not see a way to) conditionally define parameters, as PHP was previously =
doing here.

So instead, I created the TSRMLS_DN and TSRMLS_CN macros which, in the =
ZTS case, work like TSRMLS_D/TSRMLS_C, but when ZTS is off, still =
resolve to a parameter (that must always be present), which is passed =
NULL.

-John


--Apple-Mail=_6D1DD741-C43A-44F5-8329-FBA9DBBCBA5B
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJTfqf9AAoJEHUs6HKhTmiHU0UH/2xybC3Ps3/BhEcqQSShCU6m
sCrTlzUT9J+V6OzyUdhRe1LLN/y+TA+s7VFc8a8flav/Bi7F51QJKvG6Do4c1w8D
CpxIBZWYKFZS+JB11dYV/EVZzoH8V5fruhbFQMIEVUeYXFUdbYoAoX69/7P7w2MI
QHYlLuR2Bs4sdtbHAOu2fZUf9xgTHyKCb3BuLbq8OwEDHSRvhTiy/i6j/dOubtxZ
ByvojJnq2MUuyOdZC6ufVQ3ys7n+OKqJFRE0ID4m4XcAw3xW/2/gqU22/P9VcFTH
uvxyFDChoxKlqWG1hzvGsHVvdg9ALuAtoLBH5Bsvsbsnasye8/8FTO2KL1Phdwg=
=eNcg
-----END PGP SIGNATURE-----

--Apple-Mail=_6D1DD741-C43A-44F5-8329-FBA9DBBCBA5B--