Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74365
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.192.41 cause and error)
Message-ID: <537A35D9.50807@lerdorf.com>
Date: Mon, 19 May 2014 09:48:25 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Pierre Joye <pierre.php@gmail.com>
CC: Nikita Popov <nikita.ppv@gmail.com>, 
 PHP internals <internals@lists.php.net>
References: <CAF+90c8m8kMNjHOOKWs3iTxnLSVv41pk0mGjgzvvp2+Lieh+ig@mail.gmail.com>	<53788337.9090006@lerdorf.com>	<CAEZPtU7XM3Sihz0KyEpfPpYMeLZXvrz-H8SmD4LnP9gDRjNXiA@mail.gmail.com>	<53789AD9.40109@lerdorf.com> <CAEZPtU46qaKtUufaorcRp14_6wr1bHDVkJU5p+S0V+KzNF+jdg@mail.gmail.com>
In-Reply-To: <CAEZPtU46qaKtUufaorcRp14_6wr1bHDVkJU5p+S0V+KzNF+jdg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="19dc6baPODfIJi0nvsgugRFWgd1JjldhI"
Subject: Re: [PHP-DEV] Rethinking 64bit sizes and PHP-NG
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--19dc6baPODfIJi0nvsgugRFWgd1JjldhI
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 5/18/14, 9:39 AM, Pierre Joye wrote:
> On Sun, May 18, 2014 at 1:34 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wr=
ote:
>=20
>> You keep talking about side effects of the patch.
>=20
> No, what I have to keep saying, because this argument keeps coming, is
> that the ability to store >2GB string is a side effect and not a goal
> of this patch.
>=20
>> It is these side
>> effects that we have a problem with. We need a version of the patch th=
at
>> doesn't have all these undesired side effects.
>=20
> The only one, and it is disputable, is the memory usage, which is
> around 4% under real world usage (WP, Symfony, Drupal, and some other
> apps). It even performs better in many common situations.
>=20
>> You put the patch as it stands up for a vote and it is this patch we
>> have to vote on which is why I am voting no on it. It isn't some futur=
e
>> version with some unknown number of side effects removed.
>=20
> I am not sure how to formulate it in a better way but let me try again.=

>=20
> - 64bit patch has been worked on and stabilized since months
> - It is continuously tested using master, 5.5 and 5.6, using our full
> tests suite (which is much more than just running phpt in cli if you
> remember)
> - the patch is stable
>=20
> Given these points, and as it is the case with every new
> features/addition/improvements we have made, tweaks, optimization,
> etc. will happen after it gets approved and applied. Stability and
> correctness have the priority.

But that is for minor tweaks and optimizations. In this case the way to
optimize the patch is to undo the 64-bitness in a number of places where
it doesn't make sense. Putting in a software-imposed limit on class size
names while still keeping it a 64-bit value in the struct makes no
sense, for example. Same goes for lineno, line_start, line_end, num_args
and a couple more that Nikita pointed out.

And as far as I am concerned this has nothing to do with phpng. I'd
still be voting no on it as a 4% memory increase, which, by the way, you
don't even mention in the impacts section, is still too high for me when
I know parts of the 4% are completely unnecessary.

-Rasmus


--19dc6baPODfIJi0nvsgugRFWgd1JjldhI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

iEYEARECAAYFAlN6NdoACgkQlxayKTuqOuAv0gCePWrBb4+XfL7PZwzwCsoY2Cz7
nRwAnRfJpSIGQIvGnGqZZl3IYGsBkviD
=9EKk
-----END PGP SIGNATURE-----

--19dc6baPODfIJi0nvsgugRFWgd1JjldhI--