Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74361
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.220.174 cause and error)
MIME-Version: 1.0
In-Reply-To: <1400502071.2870.68.camel@guybrush>
References: <e5f19ac0089d24adc695fce93ad9bd9c.squirrel@webmail.klapt.com>
	<db6f4b4c2d10f343d4c30ee66d82b0eb@mail.gmail.com>
	<4ED7146272E04A47B986ED49E771E347BBDA6AAA06@Ikarus.ameusgmbh.intern>
	<CA+9eiLuqXs4f87bLb-vGL6AB=eEbR5khR1WtoVLwS0au7EpCOg@mail.gmail.com>
	<537333BF.7070106@lsces.co.uk>
	<CA+9eiLttV=68o37X-desnhQ9UD=GA1uwQwv4AVYrRgbXyGU3bw@mail.gmail.com>
	<5373C674.9030402@lsces.co.uk>
	<CA+9eiLtt7LCGqu8fgeehFk0wJwGcT721oFU2uX=WM-bKb4xgUQ@mail.gmail.com>
	<9fb17c9f5735c8323ff4940b452e2631.squirrel@webmail.klapt.com>
	<7478565334450718793@unknownmsgid>
	<1400502071.2870.68.camel@guybrush>
Date: Mon, 19 May 2014 17:31:15 +0400
Message-ID: <CA+9eiLsf7wpeVSKJS7i3zV=50sGFRz8+UfyQi0LuFeJ9OqDNRQ@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>, PHP internals <internals@lists.php.net>
Cc: Zeev Suraski <zeev@zend.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	Stas Malyshev <smalyshev@sugarcrm.com>
Content-Type: multipart/alternative; boundary=bcaec548a66d12428804f9c0c7f7
Subject: Re: [PHP-DEV] [VOTE] [RFC] 64 bit platform improvements for string
 length and integer
From: dmitry@zend.com (Dmitry Stogov)

--bcaec548a66d12428804f9c0c7f7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

We had a long discussion with Pierre on IRC and probably come to some
agreement.
However, we always talk as a blind with a deaf, so I can't be completely
sure :)

We agreed to make 64-bit IS_LONG and 64-bit string length on all 64-bit
systems, but don't change other core data structures (as Nikita suggested).

The main idea of the changes on top of phpng may be seen at
https://gist.github.com/dstogov/07fcbb60b1b585bcd290

I checked the patch on 64-bit Linux. The memory consumption grows, but no
so dramatic. On wordpress home page without opcache the peak_memory_usage()
showed 11043920 bytes insead of 10959456, that mean ~0.8% that we probably
can afford. Note that the original patch on the same test showed ~8% memory
consumption increase on master.

To integrate the patch into phpng we have to re-check and re-change every
place where zend_long, zend_ulong and string length are involved.

Pierre, if you agree with this proposal just change RFC accordingly, and
most people won't object.

I'm not sure if we need zend_ulong -> zend_int_t, IS_LONG -> IS_INT, size_t
-> zend_size_t renaming in thousand places. In my opinion this work is
useless but I won't object against patch just because of names. I would
suggest just 3 option for voting - "no", "yes with old names", "yes with
new names".

Thanks. Dmitry.

=E2=80=8B

--bcaec548a66d12428804f9c0c7f7--