Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:7433 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83771 invoked by uid 1010); 30 Jan 2004 18:45:10 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 83646 invoked from network); 30 Jan 2004 18:45:10 -0000 Received: from unknown (HELO edwardbear.org) (216.179.74.133) by pb1.pair.com with SMTP; 30 Jan 2004 18:45:10 -0000 Received: by edwardbear.org (Postfix, from userid 1000) id 54E4A4ED4F; Fri, 30 Jan 2004 19:43:33 +0100 (CET) Date: Fri, 30 Jan 2004 13:43:32 -0500 To: Ilia Alshanetsky Cc: Rasmus Lerdorf , internals@lists.php.net, Andi Gutmans , Zeev Suraski Message-ID: <20040130184332.GA29052@bumblebury.com> References: <200401301235.01213.ilia@prohost.org> <200401301317.43714.ilia@prohost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200401301317.43714.ilia@prohost.org> User-Agent: Mutt/1.5.5.1+cvs20040105i Subject: Re: [PHP-DEV] Warnings in include files suddenly treated as fatal From: sterling@php.net (Sterling Hughes) > + zend_file_handle file_handle; > + zend_bool can_open = zend_stream_open(inc_filename->value.str.val, &file_handle TSRMLS_CC); > + zend_file_handle_dtor(&file_handle); > + wouldn't a stat be better suited here? -sterling > + /* file open succeeded but still no op-array, likely parse error */ > + if (can_open == SUCCESS) { > +fatal_error: > + zend_error(E_ERROR, "Parse error inside included file."); > + } > + } > } > break; > case ZEND_EVAL: { > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- "Reductionists like to take things apart. The rest of us are just trying to get it together." - Larry Wall, Programming Perl, 3rd Edition