Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:7424 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12263 invoked by uid 1010); 30 Jan 2004 16:15:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 12230 invoked from network); 30 Jan 2004 16:15:50 -0000 Received: from unknown (HELO prp0.prp.physik.tu-darmstadt.de) (130.83.243.130) by pb1.pair.com with SMTP; 30 Jan 2004 16:15:50 -0000 Received: from prp0.prp.physik.tu-darmstadt.de (localhost [127.0.0.1]) by prp0.prp.physik.tu-darmstadt.de (8.12.3/8.12.3/SuSE Linux 0.6) with ESMTP id i0UGFnKf005798 for ; Fri, 30 Jan 2004 17:15:49 +0100 Received: (from swalk@localhost) by prp0.prp.physik.tu-darmstadt.de (8.12.3/8.12.3/Submit) id i0UGFnoK005797 for internals@lists.php.net; Fri, 30 Jan 2004 17:15:49 +0100 Date: Fri, 30 Jan 2004 17:15:49 +0100 To: internals@lists.php.net Message-ID: <20040130161549.GA5754@prp0.prp.physik.tu-darmstadt.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline User-Agent: Mutt/1.3.27i Subject: [PATCH] Fix for 27097 From: swalk@prp.physik.tu-darmstadt.de (Stefan Walk) --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! There is an inconsistency in the Zend API (See #27097) so integers are reported as "integer" by zend_zval_type_name but "long" by zend_parse_arg_impl causing confusion for users not knowing C, the attached patch fixes it. Stefan -- Regards, Stefan Walk --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=integer-patch Index: zend_API.c =================================================================== RCS file: /repository/ZendEngine2/zend_API.c,v retrieving revision 1.237 diff -u -r1.237 zend_API.c --- zend_API.c 23 Jan 2004 22:04:42 -0000 1.237 +++ zend_API.c 30 Jan 2004 16:11:10 -0000 @@ -236,7 +236,7 @@ int type; if ((type = is_numeric_string(Z_STRVAL_PP(arg), Z_STRLEN_PP(arg), p, &d, 0)) == 0) { - return "long"; + return "integer"; } else if (type == IS_DOUBLE) { *p = (long) d; } @@ -255,7 +255,7 @@ case IS_OBJECT: case IS_RESOURCE: default: - return "long"; + return "integer"; } } break; --J2SCkAp4GZ/dPZZf--