Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74178
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH7mQkdV=JM0R4zF5-rwMLDmZCrWWqidhZG6TcVdyffgow@mail.gmail.com>
References: <e5f19ac0089d24adc695fce93ad9bd9c.squirrel@webmail.klapt.com>
	<CA+9eiLuoJM5bwA46M_2YddTXYOhAwhii=9Ref7-NNeuRuBfW5A@mail.gmail.com>
	<CAEZPtU7zz=npjUhacwSBA6cz+kb9iBmn3fjkvYuAjqtiPQgJhw@mail.gmail.com>
	<CAF+90c9J5mtTzqFxvQHka5w5zVoGOzXNaUeYec62X_LYLOPcxA@mail.gmail.com>
	<db6f4b4c2d10f343d4c30ee66d82b0eb@mail.gmail.com>
	<CAH-PCH7mQkdV=JM0R4zF5-rwMLDmZCrWWqidhZG6TcVdyffgow@mail.gmail.com>
Date: Wed, 14 May 2014 02:37:42 -0700
Message-ID: <CAKOpQSwVOzkza9oy9EBWc+iqfabX7Un+kFxyYMwORpxNgTQsrg@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Zeev Suraski <zeev@zend.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3dce09fc28704f958ee83
Subject: Re: [PHP-DEV] [VOTE] [RFC] 64 bit platform improvements for string
 length and integer
From: kris.craig@gmail.com (Kris Craig)

--001a11c3dce09fc28704f958ee83
Content-Type: text/plain; charset=UTF-8

>
>
> Even though that I agree, that our current voting process is suboptimal,
> but I would rather see it fixed instead of ignoring the rules when it is
> inconvenient/plain wrong.
> What I do think is wrong with the current rfc, is that it states that it
> needs only 50%+1 of the votes for acceptance.
> The patch is big, it will affect every php installation (eg. not just some
> platforms), it changes the Zend Engine, and it requires some non-trivial
> effort from the extensions to support it, so even though that the direct
> impact on the userland isn't that big (code with long strings etc. which
> would fatal will now starts working, big numbers will overflow differently,
> etc.) I think it still mandates a 66%+1 vote.
>

I agree with Ferenc as far as the vote percentage is concerned.  Though I
support this RFC, it seems pretty obvious that this represents a major,
fundamental change to the codebase, sufficient to warrant the 66%+1
requirement outlined in the RFC process.  I hope it passes, but the RFC
should be updated to reflect the supermajority vote requirement, in my
opinion.

I'll admit I haven't been following this very closely, but it sounds to me
like the problem we're running into now was a lack of communication between
the Zend/main engine folks and Pierre's team.  Aside from figuring out
where the blame for this lies (I'll leave that for others to argue), it
might not be a bad idea to come up with a way to ensure this sort of
disconnect never happens again.

I believe the RFC should be implemented in spite of these new concerns
because, either way, these changes are a step in the right direction and
are, in my opinion, a long time coming.  Therefore, if that creates some
sort of conflict with recent work being done on the Zend side of things, I
think it would make the most sense for that to be where accommodations are
made rather than wasting all the work Pierre's group put into this project,
particularly since these objections, at least as I'm gathering from the
thread here, were never raised until fairly recently, after most of the
work had already been completed.

--Kris

--001a11c3dce09fc28704f958ee83--