Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74085 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70482 invoked from network); 9 May 2014 07:06:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 May 2014 07:06:53 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.99 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.99 smtp99.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.99] ([108.166.43.99:39853] helo=smtp99.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C4/7E-15882-C8E7C635 for ; Fri, 09 May 2014 03:06:52 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp5.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id BD05A1B0964; Fri, 9 May 2014 03:06:49 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp5.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 6DDC11B109F; Fri, 9 May 2014 03:06:49 -0400 (EDT) Message-ID: <536C7E88.30401@sugarcrm.com> Date: Fri, 09 May 2014 00:06:48 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Laruence CC: PHP Internals References: <536C7B33.6050704@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: ext/curl safe_upload is changed From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! >> Which tests? AFAIK the tests on Travis include curl, and they are green. > $ cat ext/curl/tests/bug27023.diff Ahh, this test requires special configuration. It'd be better to rewrite it to supply its own server and not to have to set up special server for it. But it needs either: curl_setopt($ch, CURLOPT_SAFE_UPLOAD, 0); or, even better, to be rewritten with new safe API in mind. Preferably the latter. I'll look into it on the weekend if nobody beats me to it. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227