Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74084
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.47 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <536C7B33.6050704@sugarcrm.com>
References: <CABBJUpcwV_rDcoXuY2D4Q0i6+oB1gg-QM3_w0xbeL5_3Mmo6nw@mail.gmail.com>
 <536C7B33.6050704@sugarcrm.com>
Date: Fri, 9 May 2014 14:54:17 +0800
Message-ID: <CABBJUpemScfXU2D4JZ5UEQEtg8CgEKGp64NNj8d9zKKv7TeV8w@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: ext/curl safe_upload is changed
From: laruence@php.net (Laruence)

On Fri, May 9, 2014 at 2:52 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>>      I noticed that this change : https://github.com/php/php-src/commit/24447dca
>>
>>      it has broken some tests  in ext/curl...  did you run make test before?
>
> Which tests? AFAIK the tests on Travis include curl, and they are green.
$ cat ext/curl/tests/bug27023.diff
001+ string(0) ""
002+ string(0) ""
003+ string(0) ""
004+ string(0) ""
005+ string(0) ""
001- string(%d) "curl_testdata1.txt|application/octet-stream"
002- string(%d) "curl_testdata1.txt|text/plain"
003- string(%d) "foo.txt|application/octet-stream"
004- string(%d) "foo.txt|text/plain"
005- string(%d) "foo.txt|text/plain"

thanks
>
>>      Anyway,  the current behavior is silent return if the codes uses
>> old upload style("@filename");
>
> What you mean by silent return? If unsafe upload is not turned on,
> @filename is just a variable like any other.
>
>>      I think it's better to throw a warning or something error about that....
>
> I don't think so. "@filename" is a string like any others, there's no
> reason to throw warnings on legitimate upload values.
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227



-- 
Laruence  Xinchen Hui
http://www.laruence.com/