Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74077 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 53172 invoked from network); 9 May 2014 05:48:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 May 2014 05:48:15 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.217.172 mail-lb0-f172.google.com Received: from [209.85.217.172] ([209.85.217.172:42735] helo=mail-lb0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/DA-15882-91C6C635 for ; Fri, 09 May 2014 01:48:09 -0400 Received: by mail-lb0-f172.google.com with SMTP id l4so5109750lbv.17 for ; Thu, 08 May 2014 22:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:cc:content-type; bh=TJQlx3QOuB84MBWEuISpiTtcXUJ85e4wj9Psqesc3MM=; b=UnDBKUZCYYZHK/zI2DZVBTaRx9b9uUVLp9kPlvloR1MuWRItMBoVGUm/H3oqN2ywON XS5h7jfrHcFQVWIgoZ2LuBhbFNH1HmACE0XZsqeSCBP9DFrup87LfDQdvI0iT4PV4oNV 9nBXiq2bMbtmQZJ3ueMKDhv7Sb+PQ2PBstPZ6HbaWNcd5LW/JTqxvDfSeezDTIsFHlTK bN36qMTsEUmJ/ZcSt7mKnowvUMJryrWKBnnoZcSOSKvPFxrRC6TDRG/vl5CxFa7ZAuBM SbEnM8WFXReR0qlF9OVkXY7CVY8Qav/WznyGUd/bUrQjvHpjHGi4+/mxOM3XYDqOqmPJ kCPQ== X-Received: by 10.112.14.5 with SMTP id l5mr9855411lbc.12.1399614485606; Thu, 08 May 2014 22:48:05 -0700 (PDT) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.246.36 with HTTP; Thu, 8 May 2014 22:47:45 -0700 (PDT) Date: Fri, 9 May 2014 13:47:45 +0800 X-Google-Sender-Auth: fRugDRcJINqtBOiD_mxuRZqI5ZU Message-ID: To: Stanislav Malyshev Cc: PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: ext/curl safe_upload is changed From: laruence@php.net (Laruence) Hey Stas: I noticed that this change : https://github.com/php/php-src/commit/24447dca it has broken some tests in ext/curl... did you run make test before? Anyway, the current behavior is silent return if the codes uses old upload style("@filename"); I think it's better to throw a warning or something error about that.... thoughts? thanks -- Laruence Xinchen Hui http://www.laruence.com/