Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74029 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96930 invoked from network); 7 May 2014 18:52:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 May 2014 18:52:10 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 198.187.29.233 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 198.187.29.233 imap1.ox.privateemail.com Received: from [198.187.29.233] ([198.187.29.233:51871] helo=imap1.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FF/00-30354-3D08A635 for ; Wed, 07 May 2014 14:52:09 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id F3C8920007E; Wed, 7 May 2014 14:52:00 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap1.ox.registrar-servers.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap1.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VgeBFKt30mCm; Wed, 7 May 2014 14:52:00 -0400 (EDT) Received: from [192.168.0.200] (unknown [2.218.135.6]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 0F43C200081; Wed, 7 May 2014 14:51:58 -0400 (EDT) Content-Type: multipart/alternative; boundary="Apple-Mail=_F8B1A36E-A875-4017-8B1C-002FB5CA4E93" Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) In-Reply-To: <536A7762.6090305@gmail.com> Date: Wed, 7 May 2014 19:51:54 +0100 Cc: internals@lists.php.net Message-ID: <579E2D91-6C93-49ED-AA0D-32DB76E706CC@ajf.me> References: <536A73F6.7040705@marc-bennewitz.de> <536A7762.6090305@gmail.com> To: Rowan Collins X-Mailer: Apple Mail (2.1874) Subject: Re: [PHP-DEV] [phpng] naming From: ajf@ajf.me (Andrea Faulds) --Apple-Mail=_F8B1A36E-A875-4017-8B1C-002FB5CA4E93 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 7 May 2014, at 19:11, Rowan Collins wrote: > Marc Bennewitz wrote (on 07/05/2014): >> Hi, >>=20 >> I would also prefer to name it was it represents. I mean a ZVAL = represents a PHP typed value and not a C typed one. So for example = IS_LONG would be IS_INTEGER and IS_DOUBLE would become IS_FLOAT. >>=20 >> Marc=20 >=20 > Ooh, that reminds me of something I've been meaning to file a bug for, = and maybe even attempt a patch, if I can understand where it comes from: = the message shown *to the user* when an internal function is passed an = invalid value uses "double" and "long" instead of "float" and "int". >=20 > To somebody not familiar with C or similar languages, the message = "some_function() expects parameter 1 to be long, string given" is = somewhat cryptic to say the least, particularly because long is an = adjective not a noun in standard English, so it could easily be misread = as something like "parameter 1 is not long enough". >=20 > Just a pet peeve... =85that=92s probably from zend_parse_parameters, no? -- Andrea Faulds http://ajf.me/ --Apple-Mail=_F8B1A36E-A875-4017-8B1C-002FB5CA4E93--