Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74028
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.176 as permitted sender)
Message-ID: <536A7762.6090305@gmail.com>
Date: Wed, 07 May 2014 19:11:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAEZPtU61V63QAqMdhLU-U-jf-GP+8F371unFP6DWUY5DWbd23Q@mail.gmail.com> <CA+9eiLub-dmkg7CJRP4pX1u4PiZdc=RNDHUee9u9sFbzzYcUDQ@mail.gmail.com> <536A73F6.7040705@marc-bennewitz.de>
In-Reply-To: <536A73F6.7040705@marc-bennewitz.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [phpng] naming
From: rowan.collins@gmail.com (Rowan Collins)

Marc Bennewitz wrote (on 07/05/2014):
> Hi,
>
> I would also prefer to name it was it represents. I mean a ZVAL 
> represents a PHP typed value and not a C typed one. So for example 
> IS_LONG would be IS_INTEGER and IS_DOUBLE would become IS_FLOAT.
>
> Marc 

Ooh, that reminds me of something I've been meaning to file a bug for, 
and maybe even attempt a patch, if I can understand where it comes from: 
the message shown *to the user* when an internal function is passed an 
invalid value uses "double" and "long" instead of "float" and "int".

To somebody not familiar with C or similar languages, the message 
"some_function() expects parameter 1 to be long, string given" is 
somewhat cryptic to say the least, particularly because long is an 
adjective not a noun in standard English, so it could easily be misread 
as something like "parameter 1 is not long enough".

Just a pet peeve...
-- 
Rowan Collins
[IMSoP]