Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74024 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87830 invoked from network); 7 May 2014 17:57:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 May 2014 17:57:32 -0000 Authentication-Results: pb1.pair.com header.from=php@marc-bennewitz.de; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@marc-bennewitz.de; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain marc-bennewitz.de does not designate 80.237.132.171 as permitted sender) X-PHP-List-Original-Sender: php@marc-bennewitz.de X-Host-Fingerprint: 80.237.132.171 wp164.webpack.hosteurope.de Received: from [80.237.132.171] ([80.237.132.171:36729] helo=wp164.webpack.hosteurope.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 50/15-56552-A047A635 for ; Wed, 07 May 2014 13:57:31 -0400 Received: from dslb-146-060-206-009.pools.arcor-ip.net ([146.60.206.9] helo=[192.168.178.27]); authenticated by wp164.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) id 1Wi65u-0000Bm-Ho; Wed, 07 May 2014 19:57:26 +0200 Message-ID: <536A73F6.7040705@marc-bennewitz.de> Date: Wed, 07 May 2014 19:57:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;php@marc-bennewitz.de;1399485451;8b0351c4; Subject: Re: [PHP-DEV] [phpng] naming From: php@marc-bennewitz.de (Marc Bennewitz) Hi, I would also prefer to name it was it represents. I mean a ZVAL represents a PHP typed value and not a C typed one. So for example IS_LONG would be IS_INTEGER and IS_DOUBLE would become IS_FLOAT. Marc On 07.05.2014 12:33, Dmitry Stogov wrote: > I would be just glad. Having clear uniform naming would be fine. > We should just come to agreement about the actual names and I don't think > it's a big problem. > > Thanks. Dmitry. > > > On Wed, May 7, 2014 at 12:54 PM, Pierre Joye wrote: > >> hi, >> >> would it be possible to "clean up" the naming while being at it? >> >> I would prefer longer but clearer/less confusing names rather than >> trying to reduce the type strokes. >> >> For example: >> >> ZVAL_ARR() > ZVAL_ARRAY >> ZVAL_NEW_ARR() > ZVAL_NEW_ARRAY (btw, ZVAL_NEW_ARRAY is wrongly >> documented in the wiki draft, section about arrays) >> >> Other engine's APIs use full names, to go back and forth between these >> convention is error prone and not too clean. Thoughts? >> >> Yes, it is a detail, but better to fix this now than latter :) >> >> Cheers, >> -- >> Pierre >> >> @pierrejoye | http://www.libgd.org >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> >