Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74021
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <535FC0DE.5050709@garfieldtech.com>
References: <CAFMT4NoUZ7==rmLtuohHrddNnurOe-quPL9q_=WbdNV+jo1kYA@mail.gmail.com>
	<535E9AED.2080904@garfieldtech.com>
	<CAFMT4NqP5fB4PMWn6_uWtpG=MtukMheXjd7epX4Jz7sQdydGOQ@mail.gmail.com>
	<535ECB9E.5050701@garfieldtech.com>
	<CAFMT4NqGRoU_bAaoNJfuRotXwEHAHpca2KrF5hScCMX8T5_Ohw@mail.gmail.com>
	<535FC0DE.5050709@garfieldtech.com>
Date: Thu, 8 May 2014 01:02:52 +0800
Message-ID: <CAKSD0w6smbNpE2DjKC+9cZ3DnBb=+ssRVO7mVLafSV6CaqpPqA@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134ba8ac5bb7804f8d25534
Subject: Re: [PHP-DEV] [RFC] Return Type Declarations
From: cornelius.howl@gmail.com (Lin Yo-An)

--001a1134ba8ac5bb7804f8d25534
Content-Type: text/plain; charset=ISO-8859-1

Hi,

Why using an additional ":" symbol for the return type? what about
considering this:

  function foo() string {  }

and for closure:

  $bar = 1;
  $foo = function() use ($bar) string {

  };

I think removing ":" symbol is cleaner.



On Tue, Apr 29, 2014 at 11:10 PM, Larry Garfield <larry@garfieldtech.com>wrote:

> On 4/28/14, 8:30 PM, Levi Morrison wrote:
>
>  I will attempt to contact the HHVM team (perhaps SaraG) to see if there
>>>> was
>>>> a technical reason for it.
>>>>
>>>>
>>> I would agree, and look forward to seeing their reasoning.
>>>
>>
>>
>> HHVM puts the return type before the use case because:
>>
>>    - A user is already familiar with function(): Foo
>>    - A use statement is not really part of the function signature (during
>> inheritance and such)
>>
>> Additionally, it is common to write closures using their shorthand
>> notation: ==> (see http://docs.hhvm.com/manual/en/hack.lambda.php)
>>
>> I would counter:
>>    - Use statements are special parameters (similar to constructor
>> arguments) and that putting it after the use statement makes more sense
>>    - Putting it after use statements is less ugly.
>>    - Putting it before the use statement is a bit confusing; consider this
>> Hack declaration:
>>          $i = 0;
>>          $inc = function(): Iterator<int> use(&$i) {//...
>>      It looks like the Iterator<int> is somehow using $i.
>>
>> What does this list think?
>>
>
> Honestly I don't much care for the compact lambda syntax in Hack as I like
> that PHP is explicit on variable capture.  (Javascript isn't, and it's a
> common source of errors; see the "never do this" comment on the link above.)
>
> <bikeshed>
>
> I subjectively like the return at the very end, too.  The return is the
> "last" thing that matters, so it comes at the end.  Too, it clusters all of
> the inputs together (parameters and closures) followed by the output
> (return).
>
> </bikeshed>
>
>
> --Larry Garfield
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
Best Regards,

Yo-An Lin

--001a1134ba8ac5bb7804f8d25534--