Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73993
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2FjDcKd12P63E6a-pehb=8j74z6F7qPCSd5GzSqwX4dWw@mail.gmail.com>
References: <CA+9eiLtZjPo7CJ2eVJX_XJ3tM4KadRf7UK6=7XiVkACyfUyQCw@mail.gmail.com>
	<CAHMUw2G_W=5ejYLWsf3=G=+qUW_oTW-MaFdcqB3hd1_O1w+U+A@mail.gmail.com>
	<CA+9eiLu=1cd5Ts9vRYmUnPgphUk5kh=ozdGpY5Pe8AeX6BBEbg@mail.gmail.com>
	<CAHMUw2EMqgHk4ehtq8e4h8NZ02qEhpkRkZFzTMZNTbv=45zLJQ@mail.gmail.com>
	<CA+9eiLu+W5tMqu+ugGs+BcW=C8-NMXuW8+vGfnett9JNyYqDug@mail.gmail.com>
	<CAHMUw2EPwqcwRVSqDEoU2hu57v0O+XyXBD=+mQfmjs29dRyzAw@mail.gmail.com>
	<CA+9eiLtpXtwJZP3HeK8u3QtF0hzfJ=tGnpUmy6Crw3OyfDDggg@mail.gmail.com>
	<CAHMUw2FjDcKd12P63E6a-pehb=8j74z6F7qPCSd5GzSqwX4dWw@mail.gmail.com>
Date: Tue, 6 May 2014 23:30:02 -0600
Message-ID: <CAFMT4NpWe8vNGuG6PJAEH9gN2gxxiXwssK7pWUhOBrYkPqoAUw@mail.gmail.com>
To: Tjerk Anne Meesters <datibbaw@php.net>
Cc: Dmitry Stogov <dmitry@zend.com>, Julien Pauli <jpauli@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e012953d00777b504f8c8a84a
Subject: Re: [PHP-DEV] Re: 5dee3c11 break
From: morrison.levi@gmail.com (Levi Morrison)

--089e012953d00777b504f8c8a84a
Content-Type: text/plain; charset=UTF-8

I think perhaps I haven't been clear in the past posts; I apologize. The
basic premise is that `isset` and `empty` should work the same on arrays as
they do on any array object. The problem comes from the fact that
`offsetExists` does not say that you should return false for an existing
offset with a null value.

At the end of this email is is a gauntlet of tests that *should work*, the
only exception is ExtendedArrayAccess which returns true for an existing
key with a null value (uses array_key_exists). I'd argue that
ExtendedArrayAccess uses the correct semantics and that all others should
be changed to not do the null check (only does it exist) but that would be
a big BC break. Hopefully this all makes sense.

<?php

class ExtendedArrayObject extends ArrayObject {
    function offsetExists($offset) {
        //echo "\t", __METHOD__, PHP_EOL;
        return parent::offsetExists($offset);
    }
    function offsetGet($offset) {
        //echo "\t", __METHOD__, PHP_EOL;
        return parent::offsetGet($offset);
    }
}

class ExtendedArrayAccess implements ArrayAccess {
    private $data = array();
    function __construct(array $array = array()) {
        $this->data = $array;
    }
    function offsetExists($offset) {
        return array_key_exists($offset, $this->data);
    }
    function offsetGet($offset) {
        return $this->data[$offset];
    }
    function offsetSet($offset, $value) {
        $this->data[$offset] = $value;
    }
    function offsetUnset($offset) {
        unset($this->data[$offset]);
    }
}

function createInputs() {
    return array(
        array(),
        new ArrayObject(),
        new ExtendedArrayObject(),
        new ExtendedArrayAccess(),
    );
}

class Tests {
    function isset_existing_key_with_not_empty_value($array) {
        $array['foo'] = 1;
        $this->expect(isset($array['foo']) === true, $array);
    }

    function empty_existing_key_with_not_empty_value($array) {
        $array['foo'] = 1;
        $this->expect(empty($array['foo']) === false, $array);
    }

    function isset_existing_key_with_empty_value($array) {
        $array['foo'] = 0;
        $this->expect(isset($array['foo']) === true, $array);
    }

    function empty_existing_key_with_empty_value($array) {
        $array['foo'] = 0;
        $this->expect(empty($array['foo']) === true, $array);
    }

    function isset_non_existent_key($array) {
        $this->expect(isset($array['foo']) === false, $array);
    }

    function empty_non_existent_key($array) {
        $this->expect(empty($array['foo']) === true, $array);
    }

    function isset_existing_key_with_null_value($array) {
        $array['foo'] = null;
        $this->expect(isset($array['foo']) === false, $array);
    }

    function empty_existing_key_with_null_value($array) {
        $array['foo'] = null;
        $this->expect(empty($array['foo']) === true, $array);
    }

    private function getType($v) {
       return is_array($v) ? 'array' : get_class($v);
    }

    private function expect($condition, $array) {
        if (!$condition) {
            echo "\t", $this->getType($array), ' failed ', PHP_EOL;
        }
    }
}

$tests = new Tests;
foreach (get_class_methods($tests) as $test) {
    echo "$test:", PHP_EOL;
    foreach (createInputs() as $structure) {
        $tests->$test($structure);
    }
    echo PHP_EOL;
}

--089e012953d00777b504f8c8a84a--