Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73979
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLsudYGUTYO5pVg3g3dZ2u9Ki=P_hcohP6WL0ZEQzv6Kmw@mail.gmail.com>
References: <CA+9eiLtZjPo7CJ2eVJX_XJ3tM4KadRf7UK6=7XiVkACyfUyQCw@mail.gmail.com>
	<CAHMUw2G_W=5ejYLWsf3=G=+qUW_oTW-MaFdcqB3hd1_O1w+U+A@mail.gmail.com>
	<CA+9eiLu=1cd5Ts9vRYmUnPgphUk5kh=ozdGpY5Pe8AeX6BBEbg@mail.gmail.com>
	<CAHMUw2EMqgHk4ehtq8e4h8NZ02qEhpkRkZFzTMZNTbv=45zLJQ@mail.gmail.com>
	<CA+9eiLu+W5tMqu+ugGs+BcW=C8-NMXuW8+vGfnett9JNyYqDug@mail.gmail.com>
	<CAHMUw2EPwqcwRVSqDEoU2hu57v0O+XyXBD=+mQfmjs29dRyzAw@mail.gmail.com>
	<CA+9eiLtpXtwJZP3HeK8u3QtF0hzfJ=tGnpUmy6Crw3OyfDDggg@mail.gmail.com>
	<CAFMT4NpV2zuHAWfgz-c7HSXNcsOxYR8G-F8jEP5JjvMMDFJGQw@mail.gmail.com>
	<CA+9eiLsudYGUTYO5pVg3g3dZ2u9Ki=P_hcohP6WL0ZEQzv6Kmw@mail.gmail.com>
Date: Tue, 6 May 2014 08:50:51 -0600
Message-ID: <CAFMT4NrhnsaMmObCznRjFFN0Vm=XAXV0qjcs1znMhN7RsDBLbg@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Tjerk Anne Meesters <datibbaw@php.net>, Julien Pauli <jpauli@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b2e4386cd455204f8bc5f8c
Subject: Re: [PHP-DEV] Re: 5dee3c11 break
From: morrison.levi@gmail.com (Levi Morrison)

--047d7b2e4386cd455204f8bc5f8c
Content-Type: text/plain; charset=UTF-8

On Tue, May 6, 2014 at 8:46 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
> On Tue, May 6, 2014 at 5:11 PM, Levi Morrison <levim@php.net> wrote:
>
>> On Tue, May 6, 2014 at 6:43 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>>
>>> zend_std_has_dimension() doesn't know what (check_empty == 2) means.
>>>
>>> check_empty == 0 - ISSET => we don't need to call offsetGet() and relay
>>> on
>>> offsetExists() return value.
>>> check_empty == 1 - ISEMPTY => we should call offsetGet() after
>>> offsetExists().
>>>
>>> NULL values should be handled by offsetExists().
>>>
>>
>> I am a bit curious, `isset` checks that the variable exists and is not
>> null; `empty` checks that the variable exists and is not empty. Why does
>> one call `offsetGet` and not the other? Both look at the value.
>>
>> Sorry if I missed that bit of conversation.
>>
>
> yeah, no problem :)
> I also, don't talk that my opinion is completely right.
>
> I think that we make us and users more and more troubles with this messy
> behavior.
>
> Actually, you introduced new behavior (NULL check) and broke at least ZF2
> and probably many based on it applications.
>

That isn't any new behavior, at least it shouldn't be. `isset` does not
ONLY check existence, it checks that the value is not null; see
http://php.net/isset

It leads to crash and it'll make bad php experience.
> Then someone will report it as a security problem and we all will be
> blamed :(
> We shouldn't make existing applications crash!
>

Agreed, but at least from what I understand the current behavior doesn't do
what it is supposed to anyway. Sometimes bugs become features but I really
don't see this as one of those. We should fix this. That's my $0.02.

--047d7b2e4386cd455204f8bc5f8c--