Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73976
Return-Path: <morrison.levi@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 89250 invoked from network); 6 May 2014 13:11:09 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 6 May 2014 13:11:09 -0000
Authentication-Results: pb1.pair.com header.from=morrison.levi@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=morrison.levi@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.180 as permitted sender)
X-PHP-List-Original-Sender: morrison.levi@gmail.com
X-Host-Fingerprint: 209.85.214.180 mail-ob0-f180.google.com  
Received: from [209.85.214.180] ([209.85.214.180:42779] helo=mail-ob0-f180.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 73/30-20698-C6FD8635 for <internals@lists.php.net>; Tue, 06 May 2014 09:11:09 -0400
Received: by mail-ob0-f180.google.com with SMTP id va2so7382887obc.39
        for <internals@lists.php.net>; Tue, 06 May 2014 06:11:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:date:message-id:subject
         :from:to:cc:content-type;
        bh=nw9zPon9xDSj/PFNStpd7ZXX4BqPs6Hh13pXCGQk+pc=;
        b=zicabciJyg5yQKO8TWmw1FFFxUeNU6/qTQ/WSO2lBWhZOd8wIBIpUfcSGU/hKaJ4l3
         REhRaxPmtWLB9ErUQAnn9QDlHPaJ3bUvjUCGttCvOLUAicGEQc5dBojFlFTm6nFjobLQ
         dtN924I3LlkF4rQh0tS99PClogtS6b8efcKBQCkkQ5HflSTtIDOdreoeo7eXCFf9ytKl
         TM242mIBS3qXPjTWIWGnk20Gv/xw50tOm/Y8eb5iYEnz+Gf7NKkmX5/aKRKBITyTosva
         /E58h7qhE2G+DKh9/J3jp4r2V//CoJNwAuKR547Ddd3H+gCu4jdF+0d6AcciTmdYjiqj
         xzQw==
MIME-Version: 1.0
X-Received: by 10.60.51.136 with SMTP id k8mr39466074oeo.33.1399381866186;
 Tue, 06 May 2014 06:11:06 -0700 (PDT)
Sender: morrison.levi@gmail.com
Received: by 10.76.77.100 with HTTP; Tue, 6 May 2014 06:11:06 -0700 (PDT)
In-Reply-To: <CA+9eiLtpXtwJZP3HeK8u3QtF0hzfJ=tGnpUmy6Crw3OyfDDggg@mail.gmail.com>
References: <CA+9eiLtZjPo7CJ2eVJX_XJ3tM4KadRf7UK6=7XiVkACyfUyQCw@mail.gmail.com>
	<CAHMUw2G_W=5ejYLWsf3=G=+qUW_oTW-MaFdcqB3hd1_O1w+U+A@mail.gmail.com>
	<CA+9eiLu=1cd5Ts9vRYmUnPgphUk5kh=ozdGpY5Pe8AeX6BBEbg@mail.gmail.com>
	<CAHMUw2EMqgHk4ehtq8e4h8NZ02qEhpkRkZFzTMZNTbv=45zLJQ@mail.gmail.com>
	<CA+9eiLu+W5tMqu+ugGs+BcW=C8-NMXuW8+vGfnett9JNyYqDug@mail.gmail.com>
	<CAHMUw2EPwqcwRVSqDEoU2hu57v0O+XyXBD=+mQfmjs29dRyzAw@mail.gmail.com>
	<CA+9eiLtpXtwJZP3HeK8u3QtF0hzfJ=tGnpUmy6Crw3OyfDDggg@mail.gmail.com>
Date: Tue, 6 May 2014 07:11:06 -0600
X-Google-Sender-Auth: TJDGlzZhguKGC3udfHBYnBioOfQ
Message-ID: <CAFMT4NpV2zuHAWfgz-c7HSXNcsOxYR8G-F8jEP5JjvMMDFJGQw@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Tjerk Anne Meesters <datibbaw@php.net>, Julien Pauli <jpauli@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c32b200a0d7204f8bafb5f
Subject: Re: [PHP-DEV] Re: 5dee3c11 break
From: levim@php.net (Levi Morrison)

--001a11c32b200a0d7204f8bafb5f
Content-Type: text/plain; charset=UTF-8

On Tue, May 6, 2014 at 6:43 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> zend_std_has_dimension() doesn't know what (check_empty == 2) means.
>
> check_empty == 0 - ISSET => we don't need to call offsetGet() and relay on
> offsetExists() return value.
> check_empty == 1 - ISEMPTY => we should call offsetGet() after
> offsetExists().
>
> NULL values should be handled by offsetExists().
>

I am a bit curious, `isset` checks that the variable exists and is not
null; `empty` checks that the variable exists and is not empty. Why does
one call `offsetGet` and not the other? Both look at the value.

Sorry if I missed that bit of conversation.

--001a11c32b200a0d7204f8bafb5f--