Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73967
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.212.174 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2G_W=5ejYLWsf3=G=+qUW_oTW-MaFdcqB3hd1_O1w+U+A@mail.gmail.com>
References: <CA+9eiLtZjPo7CJ2eVJX_XJ3tM4KadRf7UK6=7XiVkACyfUyQCw@mail.gmail.com>
	<CAHMUw2G_W=5ejYLWsf3=G=+qUW_oTW-MaFdcqB3hd1_O1w+U+A@mail.gmail.com>
Date: Tue, 6 May 2014 15:25:22 +0400
Message-ID: <CA+9eiLu=1cd5Ts9vRYmUnPgphUk5kh=ozdGpY5Pe8AeX6BBEbg@mail.gmail.com>
To: Tjerk Anne Meesters <datibbaw@php.net>
Cc: Julien Pauli <jpauli@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d043c0864ed1ff404f8b980f0
Subject: Re: 5dee3c11 break
From: dmitry@zend.com (Dmitry Stogov)

--f46d043c0864ed1ff404f8b980f0
Content-Type: text/plain; charset=UTF-8

I didn't review you patch careful, but why do you need to call offsetGet()
when offsetExists() must be enough?
is it for empty()?
Then you probably should implement it a way similar to
zend_std_has_dimension() in Zend/zend_object_handlers.c.
call offsetExists() and then offsetGet() if necessary.

Thanks. Dmitry.


On Tue, May 6, 2014 at 2:31 PM, Tjerk Anne Meesters <datibbaw@php.net>wrote:

> Hi Dmitry,
>
> On Tue, May 6, 2014 at 4:11 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Tjerk,
>>
>> your commit broke the code that worked fine before (still works in 5.5
>> but broken in 5.6 and above).
>> It leads into infinity recursion until stack overflow.
>>
>> It must be fixed or reverted.
>>
>
> This has been mentioned by Jakub before and a fix to ZF2 has already been
> merged:
>
> https://github.com/zendframework/zf2/pull/6096
>
> The previous code and my patch basically cannot coexist; it used to work
> in 5.6 before, but only by the "virtue" of an unfortunate implementation.
>
> I believe this is not the only 5.6 issue that ZF2 is dealing with, but if
> you feel that this breaks too many things for a 5.x release I suppose we
> can revert it in PHP-5.6 and keep it for PHP-6?
>
> Let me know.
>
>
>> Thanks. Dmitry.
>>
>> <?php
>> class Parameters extends ArrayObject {
>>     public function __construct(array $values = null) {
>>         if (null === $values) {
>>             $values = array();
>>         }
>>         parent::__construct($values, ArrayObject::ARRAY_AS_PROPS);
>>     }
>>     public function offsetGet($name) {
>>         if (isset($this[$name])) {
>>             return parent::offsetGet($name);
>>         }
>>         return null;
>>     }
>> }
>> $x = new Parameters();
>> var_dump($x['foo']);
>> $x['foo'] = 'bar';
>> var_dump($x['foo']);
>> ?>
>>
>
>
>
> --
> --
> Tjerk
>

--f46d043c0864ed1ff404f8b980f0--