Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73914
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 74.125.82.178 cause and error)
MIME-Version: 1.0
In-Reply-To: <BLU436-SMTP23069698A0B173390A9BC0BE24C0@phx.gbl>
References: <CA+9eiLtKFMWn7AXyS3_fni1Dyerx3DUW7imZ08P9gLr_FY=TaA@mail.gmail.com>
	<1CB4131A-13AA-4061-94F6-CA3B3EB1DB3E@ajf.me>
	<CA+9eiLs7cCV=QvJ28OfzNqOD_bD19UEarKkv_Cvg_im_txYx3Q@mail.gmail.com>
	<5FB10F5A-C78A-47C7-ABD1-A1CA1426B122@ajf.me>
	<0B48F9CB-D504-4274-8CE9-B330A4EDC4BD@zend.com>
	<BBFDE63E-C7A0-4DDD-9767-66A19EAC6F71@ajf.me>
	<CA+9eiLtBo+j-J-1Cr=m32t4eA1_5mKSC05qBOeWs63JOyqa0LA@mail.gmail.com>
	<BLU436-SMTP23069698A0B173390A9BC0BE24C0@phx.gbl>
Date: Mon, 5 May 2014 23:32:58 +0400
Message-ID: <CA+9eiLuF=MOEfLGGqv3HRnMKtwEZC59Zqop+C80zGe6TgXob+Q@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d043c0864e2ac1804f8ac3234
Subject: Re: [PHP-DEV] phpng: Refactored PHP Engine with Big Performance Improvement
From: dmitry@zend.com (Dmitry Stogov)

--f46d043c0864e2ac1804f8ac3234
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Bob,

Actually, our patches were orthogonal, resolving the same hack in different
ways.
Sorry, I had a lot of work, and missed your patch when you committed it.
Then I just wasn't able to merge them in reasonable time.

We will need to discuss it in more details and then reimplement on top of
phpng or revert in master.

The thing I don't like in the patch, that you converted every
IS_CONSTANT_ARRAY into IS_CONSTANT_AST.
With this approach all the constant arrays have to be evaluated at run-time=
.
However, I think about optimization when we won't copy constant arrays
(without symbolic constants) from shared memory at all.
I might be wrong, or misunderstand something in your patch, so we'll
definitely need to talk, but now I would prefer to close the known problems
first.

Let's speak on next week.

Thanks. Dmitry.




On Mon, May 5, 2014 at 11:08 PM, Bob Weinand <bobwei9@hotmail.com> wrote:

> Am 5.5.2014 um 16:31 schrieb Dmitry Stogov <dmitry@zend.com>:
>
> I'm doing it right now: https://wiki.php.net/phpng-int
>
> Thanks. Dmitry.
>
>
> On Mon, May 5, 2014 at 6:30 PM, Andrea Faulds <ajf@ajf.me> wrote:
>
> Hmm. This is unrelated, but while you=E2=80=99re busy refactoring PHP, co=
uld you
> comment and document the bits you refactor a bit more? More documentation
> can only be a good thing, and it=E2=80=99s something Zend is sorely lacki=
ng.
>
> --
> Andrea Faulds
> http://ajf.me/
>
>
> Nice work!
>
> Just wondering why
> http://git.php.net/?p=3Dphp-src.git;a=3Dcommitdiff;h=3Df614fc68984b2d7fce=
3f275b8106955b5d910472was reverted in phpng?
>
> Is there any real reason to still use IS_CONSTANT_ARRAY? The AST variant
> is much nicer, fixes a bug and removes the IS_CONSTANT_INDEX hack.
>
> Bob
>
>
>
>
>

--f46d043c0864e2ac1804f8ac3234--