Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73838
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <535ECB9E.5050701@garfieldtech.com>
References: <CAFMT4NoUZ7==rmLtuohHrddNnurOe-quPL9q_=WbdNV+jo1kYA@mail.gmail.com>
	<535E9AED.2080904@garfieldtech.com>
	<CAFMT4NqP5fB4PMWn6_uWtpG=MtukMheXjd7epX4Jz7sQdydGOQ@mail.gmail.com>
	<535ECB9E.5050701@garfieldtech.com>
Date: Mon, 28 Apr 2014 19:30:01 -0600
Message-ID: <CAFMT4NqGRoU_bAaoNJfuRotXwEHAHpca2KrF5hScCMX8T5_Ohw@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2da9ceab35304f8245e6a
Subject: Re: [PHP-DEV] [RFC] Return Type Declarations
From: morrison.levi@gmail.com (Levi Morrison)

--001a11c2da9ceab35304f8245e6a
Content-Type: text/plain; charset=UTF-8

>
> As far as the order of keywords in a closure, what order does Hack use?
>>
>>>   The rest of the syntax seems based on it, so it seems sensible to
>>> follow
>>> suit.  (I couldn't find that information from 60 seconds on hacklang.org
>>> ,
>>> but it may be there.)
>>>
>>
>>
>> At least in the 2.4 branch of HHVM (which I have installed) they put it
>> before the use statement. Now that I have thought about this more, this is
>> a poor decision:
>>
>>   * use statements are basically parameters at construction time instead
>> of
>> runtime
>>   * putting the return type before the use statement looks really ugly
>>
>> I will attempt to contact the HHVM team (perhaps SaraG) to see if there
>> was
>> a technical reason for it.
>>
>
> I would agree, and look forward to seeing their reasoning.


HHVM puts the return type before the use case because:

  - A user is already familiar with function(): Foo
  - A use statement is not really part of the function signature (during
inheritance and such)

Additionally, it is common to write closures using their shorthand
notation: ==> (see http://docs.hhvm.com/manual/en/hack.lambda.php)

I would counter:
  - Use statements are special parameters (similar to constructor
arguments) and that putting it after the use statement makes more sense
  - Putting it after use statements is less ugly.
  - Putting it before the use statement is a bit confusing; consider this
Hack declaration:
        $i = 0;
        $inc = function(): Iterator<int> use(&$i) {//...
    It looks like the Iterator<int> is somehow using $i.

What does this list think?

--001a11c2da9ceab35304f8245e6a--