Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73812 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56679 invoked from network); 26 Apr 2014 10:26:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Apr 2014 10:26:01 -0000 Authentication-Results: pb1.pair.com smtp.mail=sebastian@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=sebastian@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 93.190.64.237 as permitted sender) X-PHP-List-Original-Sender: sebastian@php.net X-Host-Fingerprint: 93.190.64.237 mail-1.de-punkt.de Received: from [93.190.64.237] ([93.190.64.237:46908] helo=mail-1.de-punkt.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1B/03-34885-7B98B535 for ; Sat, 26 Apr 2014 06:26:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mail-1.de-punkt.de (Postfix) with ESMTP id 16B583A889 for ; Sat, 26 Apr 2014 12:25:56 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail-1.de-punkt.de Received: from mail-1.de-punkt.de ([127.0.0.1]) by localhost (mail-1.de-punkt.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SEH07yPfYhLM for ; Sat, 26 Apr 2014 12:25:55 +0200 (CEST) Received: from [192.168.178.24] (p4FC7C7C7.dip0.t-ipconnect.de [79.199.199.199]) (Authenticated sender: php@sebastian-bergmann.de) by mail-1.de-punkt.de (Postfix) with ESMTPSA id BA6563A30D for ; Sat, 26 Apr 2014 12:25:55 +0200 (CEST) Message-ID: <535B89BA.7060504@php.net> Date: Sat, 26 Apr 2014 12:26:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: internals@lists.php.net References: <535A13E1.3050106@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [VOTE] CI tests RFC From: sebastian@php.net (Sebastian Bergmann) Am 26.04.2014 11:57, schrieb Pierre Joye: > - review > - ask for fix > - revert > > I do not see what is rude here. However not fixing a patch within a > couple of days (as in commit and run), after other has reported > issues, is actually rude. Agreed; committing or submitting a patch without making sure that it does not break any tests is rude.