Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73772
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.173 as permitted sender)
MIME-Version: 1.0
Date: Thu, 24 Apr 2014 14:31:49 +0400
Message-ID: <CA+CZih6jO_08SK6pFHnAHeK_L5M7vVSUiuzY7q43Oprh-JtReQ@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=047d7b3a94c087ad5d04f7c75cdb
Subject: Bug in run-tests.php for an extension which depends on another extension.
From: dmitry.koterov@gmail.com (Dmitry Koterov)

--047d7b3a94c087ad5d04f7c75cdb
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello.

Johannes Schl=C3=BCter from pecl-dev has given me an advice to write to thi=
s
maillist about my tiny patch to run-tests.php. Hope it could be helpful.
Here is the pull request:

https://github.com/php/php-src/pull/650

=3D=3D=3D=3D=3D=3D=3D

Now run-tests.php does not clearly support testing of extensions which
depend on other extensions.
It produces nasty warnings in this case when I run "phpize; ./configure;
make test" (it's a pity that
this warning is useless: it is produced not in test logic, but in the
informational block generating code).
I am the author of such extension (my extension depends on dom.so), and I
suppose I see an easy
way to fix this warning.

Assume we created an extension A.so, which depends on another extension
(e.g. dom.so).
And we run "phpize; ./configure; make test" on A extension. In this case
Makefile of A
calls "run-tests.php ... -d extension=3DA.so", which calls the following
inside itself:

php -n -c '~/A/tmp-php.ini' ... -d extension_dir=3D~/A/modules/ -d
extension=3DA.so run-test-info.php

But you see that it doesn't include "-d extension=3Ddom.so" as well, becaus=
e
it has no idea about
extension dependencies. So the run-test-info.php below fails with:

PHP Warning: Cannot load module 'A' because required module 'dom' is not
loaded.

BTW all phpt tests of A extension succeed: they HAVE informations about
extension dependencies
via "--EXTENSIONS--" section in phpt files, which mentions dom.so
dependency. So, we do not
need "-d extension=3D-..." during internal call of run-test-info.php, this =
is
only an informational call
(to print out PHP SAPI version etc.). Real phpt tests are executed
separately (and they, of course,
have "-d extension=3DA.so" not removed).

--047d7b3a94c087ad5d04f7c75cdb--