Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73770
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAPg3XxJ01eoJbJ1ZE25FOGKF=bwCAhhUi1_rWrjtcoF4-PmEhw@mail.gmail.com>
References: <CAHMUw2FXpXiShBSOcFHmsOmFmWpej0o_zX+mi37LuQ10AQOc-w@mail.gmail.com>
	<CAF+90c8VFb60TKtjuUdpFqfW5mkbP5OqZOPFc-f8eVT2EwbADg@mail.gmail.com>
	<CAPg3XxJ01eoJbJ1ZE25FOGKF=bwCAhhUi1_rWrjtcoF4-PmEhw@mail.gmail.com>
Date: Thu, 24 Apr 2014 11:28:01 +0800
Message-ID: <CAHMUw2Fw6n3R+zYK29frHPcgu5M94=qyXZazgkWMopF+gxY0+g@mail.gmail.com>
To: Peter Cowburn <petercowburn@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec548a9b7afbbab04f7c16fd4
Subject: Re: [PHP-DEV] [pr-645] Add offset to reset() and end()
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--bcaec548a9b7afbbab04f7c16fd4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Peter,


On Sat, Apr 19, 2014 at 7:50 AM, Peter Cowburn <petercowburn@gmail.com>wrot=
e:

>
>
>
> On 18 April 2014 09:58, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
>> On Fri, Apr 18, 2014 at 2:39 AM, Tjerk Meesters <tjerk.meesters@gmail.co=
m
>> >wrote:
>>
>> > Hi,
>> >
>> > I've added a PR that satisfies #31375.
>> >
>> > https://github.com/php/php-src/pull/645
>> >
>> > It adds a second optional argument to reset() and end() to specify the
>> > number of elements that should be skipped (forward or backward).
>>
>
> The last time that I can remember discussion of something like
> array_seek() [1]=E2=80=93which is what this seems like it actually wants =
to be=E2=80=93the
> reception was fairly positive, but the idea just fizzled out.  I=E2=80=99=
d
> recommend looking back over the archives for other similar discussions.
>

Thanks for digging up the earlier discussion; taking also into account the
other feedback I have received, I have updated the PR:

https://github.com/php/php-src/pull/645

It takes some cues from the earlier `array_seek()` proposal but:
1. doesn't update the internal pointer if seek() failed
2. returns boolean result to indicate success / failure
3. is not called `array_seek()` ;-)

I would be perfectly okay if this gets shut down as well, but at least I've
tried :)

Example of "iterate over last 50 array entries":

if (array_seek($array, -50, SEEK_END)) {
    while ($data =3D each($array)) {
        ...
    }
}


> I would be -1 on changing reset() and end() to make them be able to not
> reset the array pointer, or not move to the end, respectively; especially
> where a neater (IMO) alternative has already been discussed.
>
>  [1] http://markmail.org/thread/sczgritz5jcccnwh [PHP-DEV] array_seek
> function
>
>
>
>>  >
>> > Currently, negative offsets are ignored. Should we raise a notice for
>> such
>> > cases? Something like:
>> >
>> > "Negative offsets are not supported."
>> >
>> > Any feedback is welcome. Thanks!
>> >
>>
>> The reset() part seems to already be adequately covered by LimitIterator=
.
>> Personally I'd prefer not to add any new functionality to
>> reset/current/...
>> because you oughtn't be using those functions anyway. Trying to do manua=
l
>> array iteration with them is both somewhat unsafe (think nested iteratio=
n)
>> and makes for really ugly code.
>>
>> // skip 10 elements of $it. Can be an ArrayIterator, of course
>> foreach (new LimitIterator($it, 10) as $k =3D> $v) { ... }
>>
>> Nikita
>>
>
>


--=20
--
Tjerk

--bcaec548a9b7afbbab04f7c16fd4--