Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73742
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8VFb60TKtjuUdpFqfW5mkbP5OqZOPFc-f8eVT2EwbADg@mail.gmail.com>
References: <CAHMUw2FXpXiShBSOcFHmsOmFmWpej0o_zX+mi37LuQ10AQOc-w@mail.gmail.com>
 <CAF+90c8VFb60TKtjuUdpFqfW5mkbP5OqZOPFc-f8eVT2EwbADg@mail.gmail.com>
Date: Sat, 19 Apr 2014 00:50:58 +0100
Message-ID: <CAPg3XxJ01eoJbJ1ZE25FOGKF=bwCAhhUi1_rWrjtcoF4-PmEhw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Tjerk Meesters <tjerk.meesters@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b674408ab526304f759d481
Subject: Re: [PHP-DEV] [pr-645] Add offset to reset() and end()
From: petercowburn@gmail.com (Peter Cowburn)

--047d7b674408ab526304f759d481
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 18 April 2014 09:58, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Fri, Apr 18, 2014 at 2:39 AM, Tjerk Meesters <tjerk.meesters@gmail.com
> >wrote:
>
> > Hi,
> >
> > I've added a PR that satisfies #31375.
> >
> > https://github.com/php/php-src/pull/645
> >
> > It adds a second optional argument to reset() and end() to specify the
> > number of elements that should be skipped (forward or backward).
>

The last time that I can remember discussion of something like array_seek()
[1]=E2=80=93which is what this seems like it actually wants to be=E2=80=93t=
he reception was
fairly positive, but the idea just fizzled out.  I=E2=80=99d recommend look=
ing back
over the archives for other similar discussions.

I would be -1 on changing reset() and end() to make them be able to not
reset the array pointer, or not move to the end, respectively; especially
where a neater (IMO) alternative has already been discussed.

 [1] http://markmail.org/thread/sczgritz5jcccnwh [PHP-DEV] array_seek
function



>  >
> > Currently, negative offsets are ignored. Should we raise a notice for
> such
> > cases? Something like:
> >
> > "Negative offsets are not supported."
> >
> > Any feedback is welcome. Thanks!
> >
>
> The reset() part seems to already be adequately covered by LimitIterator.
> Personally I'd prefer not to add any new functionality to reset/current/.=
..
> because you oughtn't be using those functions anyway. Trying to do manual
> array iteration with them is both somewhat unsafe (think nested iteration=
)
> and makes for really ugly code.
>
> // skip 10 elements of $it. Can be an ArrayIterator, of course
> foreach (new LimitIterator($it, 10) as $k =3D> $v) { ... }
>
> Nikita
>

--047d7b674408ab526304f759d481--