Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73741
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2FXpXiShBSOcFHmsOmFmWpej0o_zX+mi37LuQ10AQOc-w@mail.gmail.com>
References: <CAHMUw2FXpXiShBSOcFHmsOmFmWpej0o_zX+mi37LuQ10AQOc-w@mail.gmail.com>
Date: Fri, 18 Apr 2014 10:58:54 +0200
Message-ID: <CAF+90c8VFb60TKtjuUdpFqfW5mkbP5OqZOPFc-f8eVT2EwbADg@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2ed6cf5038d04f74d5b28
Subject: Re: [PHP-DEV] [pr-645] Add offset to reset() and end()
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11c2ed6cf5038d04f74d5b28
Content-Type: text/plain; charset=UTF-8

On Fri, Apr 18, 2014 at 2:39 AM, Tjerk Meesters <tjerk.meesters@gmail.com>wrote:

> Hi,
>
> I've added a PR that satisfies #31375.
>
> https://github.com/php/php-src/pull/645
>
> It adds a second optional argument to reset() and end() to specify the
> number of elements that should be skipped (forward or backward).
>
> Currently, negative offsets are ignored. Should we raise a notice for such
> cases? Something like:
>
> "Negative offsets are not supported."
>
> Any feedback is welcome. Thanks!
>

The reset() part seems to already be adequately covered by LimitIterator.
Personally I'd prefer not to add any new functionality to reset/current/...
because you oughtn't be using those functions anyway. Trying to do manual
array iteration with them is both somewhat unsafe (think nested iteration)
and makes for really ugly code.

// skip 10 elements of $it. Can be an ArrayIterator, of course
foreach (new LimitIterator($it, 10) as $k => $v) { ... }

Nikita

--001a11c2ed6cf5038d04f74d5b28--