Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73695 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8047 invoked from network); 15 Apr 2014 09:02:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Apr 2014 09:02:02 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.44 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.192.44 mail-qg0-f44.google.com Received: from [209.85.192.44] ([209.85.192.44:46778] helo=mail-qg0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E6/61-27880-585FC435 for ; Tue, 15 Apr 2014 05:01:58 -0400 Received: by mail-qg0-f44.google.com with SMTP id j107so171691qga.3 for ; Tue, 15 Apr 2014 02:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=89P0xT4Fa1mzFRysJ/4D0uSb250ZydEINKaGNzpICro=; b=rgS2FwguuwQp5OOtIv2TOXx0UnDAwMpcVTk3F8ma0Ueiq/9KEUz89vc8Z6AamuPRoP hLwl974NKMqYZiL/IHHz/M8/SoLm9TUHEh2Rr9qoj+jFJrMSwOpevpDQnYR94XdblBhe rxAF85dmQbOoBfjrHVXkprehZt4PGDNVaDPr38TjoGWoBxdYADVjxUR2Vg49Ssk4hqlV 9U6mmeZZ8LoteVVXKPsjSf2qQkJDgc5W0rLdJ1S29a1r9nt9HUT15jpKwrvJBDXX2T1s PeNe8ME05hc7ySPgDDa6YaDt1wkkS7SOxcm93F7OmNHe8VWaATgDptduz/CksEJM2OIr lUDw== MIME-Version: 1.0 X-Received: by 10.140.90.84 with SMTP id w78mr774044qgd.52.1397552514383; Tue, 15 Apr 2014 02:01:54 -0700 (PDT) Received: by 10.140.17.34 with HTTP; Tue, 15 Apr 2014 02:01:54 -0700 (PDT) In-Reply-To: <534CF1FB.30706@anderiasch.de> References: <534C2133.8010402@sugarcrm.com> <534C3681.6030201@php.net> <534CF1FB.30706@anderiasch.de> Date: Tue, 15 Apr 2014 11:01:54 +0200 Message-ID: To: Florian Anderiasch Cc: Sebastian Bergmann , PHP Internals Content-Type: multipart/alternative; boundary=001a11c117a82cc4d004f7110db9 Subject: Re: [PHP-DEV] [RFC] keeping unit tests green From: tyra3l@gmail.com (Ferenc Kovacs) --001a11c117a82cc4d004f7110db9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Apr 15, 2014 at 10:46 AM, Florian Anderiasch wrot= e: > > > On 04/14/2014 09:26 PM, Sebastian Bergmann wrote: > > Am 14.04.2014 19:56, schrieb Stas Malyshev: > >> As promised, I have created an RFC on unit test policy, here: > >> https://wiki.php.net/rfc/travis_ci > > > > Nitpicking: To the best of my knowledge, PHP does not have a single > > unit test. PHPT tests, of which we have many, are integration tests. > > If > > https://github.com/php/php-src/blob/master/ext/standard/tests/strings/bin= 2hex.phpt > (and most of the other function tests) is not a unit test I'm not sure > how you would set the requirements. > > Greetings, > Florian > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > they are still testing our PHP_FUNCTION() macro, and zend_parse_parameters(), etc. instead of testing the php_bin2hex() function= . from the userland POV, they could be seen as unit tests, but they still test the given unit from a mile away through multiple layers of cruft. --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu --001a11c117a82cc4d004f7110db9--