Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73694 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6166 invoked from network); 15 Apr 2014 08:46:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Apr 2014 08:46:59 -0000 Authentication-Results: pb1.pair.com smtp.mail=ml@anderiasch.de; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ml@anderiasch.de; sender-id=unknown Received-SPF: error (pb1.pair.com: domain anderiasch.de from 81.169.138.148 cause and error) X-PHP-List-Original-Sender: ml@anderiasch.de X-Host-Fingerprint: 81.169.138.148 ares.art-core.org Received: from [81.169.138.148] ([81.169.138.148:56036] helo=ares.art-core.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CE/01-27880-FF1FC435 for ; Tue, 15 Apr 2014 04:46:56 -0400 Received: from [192.168.23.61] (p54A76C46.dip0.t-ipconnect.de [84.167.108.70]) by ares.art-core.org (mail.art-core.org) with ESMTPSA id BEFB72EE251; Tue, 15 Apr 2014 10:46:52 +0200 (CEST) Message-ID: <534CF1FB.30706@anderiasch.de> Date: Tue, 15 Apr 2014 10:46:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Thunderbird/29.0a2 MIME-Version: 1.0 To: Sebastian Bergmann , internals@lists.php.net References: <534C2133.8010402@sugarcrm.com> <534C3681.6030201@php.net> In-Reply-To: <534C3681.6030201@php.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] keeping unit tests green From: ml@anderiasch.de (Florian Anderiasch) On 04/14/2014 09:26 PM, Sebastian Bergmann wrote: > Am 14.04.2014 19:56, schrieb Stas Malyshev: >> As promised, I have created an RFC on unit test policy, here: >> https://wiki.php.net/rfc/travis_ci > > Nitpicking: To the best of my knowledge, PHP does not have a single > unit test. PHPT tests, of which we have many, are integration tests. If https://github.com/php/php-src/blob/master/ext/standard/tests/strings/bin2hex.phpt (and most of the other function tests) is not a unit test I'm not sure how you would set the requirements. Greetings, Florian