Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73637
Return-Path: <cwscribner@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 612 invoked from network); 8 Apr 2014 12:46:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 8 Apr 2014 12:46:14 -0000
Authentication-Results: pb1.pair.com header.from=cwscribner@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=cwscribner@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.175 as permitted sender)
X-PHP-List-Original-Sender: cwscribner@gmail.com
X-Host-Fingerprint: 209.85.212.175 mail-wi0-f175.google.com  
Received: from [209.85.212.175] ([209.85.212.175:64809] helo=mail-wi0-f175.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 66/68-41229-59FE3435 for <internals@lists.php.net>; Tue, 08 Apr 2014 08:46:13 -0400
Received: by mail-wi0-f175.google.com with SMTP id cc10so6945722wib.2
        for <internals@lists.php.net>; Tue, 08 Apr 2014 05:46:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=ilABDZnCuoWxSMS6DsAhb1INgm0T81sX58AItvuunsY=;
        b=ihT5+tssHF95R+7+utsu/JBcV8rxfEdSoHz0UuOzRXYfUxEt2NRYL0EJ0yD/W+qFlu
         4FedH4+SLwhjuTeQ0I4UPIu7r8KQkMY46iF9z53kh9skKI/zTtP+NLuZe3VwKj1W60vJ
         5LSR7wqUHPWitwkRcazwkJ/NrBTDHeB8nEzKl2jdLG6QBN4tlmpVpNv3guBpZ6fCbaRZ
         pAjCZch8AM4wok6h9kZkURxwK2AagJozX2gAKgsCHJCeB5GJ8sJ/H3M07IwbWo6um1yY
         67fZVHPNm48f+TlzspVoWcbkmMMU0A+l9W9pd9fkDVebIgPPIgU9XlwEetHfREx3Nu7Q
         g+/w==
MIME-Version: 1.0
X-Received: by 10.180.12.43 with SMTP id v11mr31527982wib.33.1396961169509;
 Tue, 08 Apr 2014 05:46:09 -0700 (PDT)
Received: by 10.227.234.7 with HTTP; Tue, 8 Apr 2014 05:46:09 -0700 (PDT)
Received: by 10.227.234.7 with HTTP; Tue, 8 Apr 2014 05:46:09 -0700 (PDT)
In-Reply-To: <5341EA15.4020206@sugarcrm.com>
References: <CAO6UHD40eL2eW9T_1mtTnnxcBavSkV51nZ_uTLLc9nWYCbxo=w@mail.gmail.com>
	<5341EA15.4020206@sugarcrm.com>
Date: Tue, 8 Apr 2014 08:46:09 -0400
Message-ID: <CAO6UHD4mtcGPXt_0U3i=Rw1EPEpA7_aqOWn2J8LDKct1H+ePfw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2259046129804f6875e2c
Subject: Re: [PHP-DEV] Pull Request #595
From: cwscribner@gmail.com (Chad Scribner)

--001a11c2259046129804f6875e2c
Content-Type: text/plain; charset=ISO-8859-1

Absolutely.  Sorry for the delay!  I've been in the process of rewiring a
portion of my house so my dev time has been limited.
On Apr 6, 2014 7:58 PM, "Stas Malyshev" <smalyshev@sugarcrm.com> wrote:

> Hi!
>
> > I'm here to request that my pull request #595 get merged.  It's a fix for
> > bug #52384 regarding PDO::debugDumpParams().  I've put the code and a
> phpt
> > into the PR.  You'll notice in the PR that the Travis CI build failed but
> > after investigating, my test did not fail.  It looks as though it was due
> > to other code.  This is my first time making a contribution so feel free
> to
> > let me know if there's anything else I need to add.  Thanks!
>
> There are some notes on the pull, mainly about code style but also on
> substance. Could you look at them and try to address them?
>
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>

--001a11c2259046129804f6875e2c--