Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73625
Return-Path: <anatol.php@belski.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 36997 invoked from network); 7 Apr 2014 15:45:46 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 7 Apr 2014 15:45:46 -0000
Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
X-PHP-List-Original-Sender: anatol.php@belski.net
X-Host-Fingerprint: 85.214.73.107 klapt.com  
Received: from [85.214.73.107] ([85.214.73.107:59465] helo=klapt.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 13/02-21811-828C2435 for <internals@lists.php.net>; Mon, 07 Apr 2014 11:45:45 -0400
Received: by klapt.com (Postfix, from userid 33)
	id DDE7A23D611B; Mon,  7 Apr 2014 17:45:41 +0200 (CEST)
Received: from 178.2.23.158
        (SquirrelMail authenticated user anatol@belski.net)
        by webmail.klapt.com with HTTP;
        Mon, 7 Apr 2014 17:45:41 +0200
Message-ID: <236c21e19ca5d68d2798e4a69c60eacc.squirrel@webmail.klapt.com>
In-Reply-To:
 <CAH-PCH696KavtwuDk=H792P3r_mgncfGxGJbinTvgKQe_VXtNA@mail.gmail.com>
References:
    <CAH-PCH696KavtwuDk=H792P3r_mgncfGxGJbinTvgKQe_VXtNA@mail.gmail.com>
Date: Mon, 7 Apr 2014 17:45:41 +0200
To: "Ferenc Kovacs" <tyra3l@gmail.com>
Cc: "Anatoliy Belsky" <ab@php.net>,
 "PHP Internals" <internals@lists.php.net>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] failing intl test
 (ext/intl/tests/dateformat_format_variant2.phpt)
From: anatol.php@belski.net ("Anatol Belski")

Hi Ferenc,

On Mon, April 7, 2014 14:48, Ferenc Kovacs wrote:
> Hi,
>
>
> I have never managed to make this test pass for me, even thought that I
> was trying with different ICU versions. I'm currently testing with ICU 52.1
> from homebrew on Mavericks and with the same ICU version on debian wheezy
> and it fails with the same diff:
>
> 209+    'timezone_type' => 2,^M
> 210+    'timezone' => 'PDT',^M
> 209-    'timezone_type' => 3,^M
> 210-    'timezone' => 'America/Los_Angeles',^M
> 217+    'timezone_type' => 2,^M
> 218+    'timezone' => 'PDT',^M
> 217-    'timezone_type' => 3,^M
> 218-    'timezone' => 'America/Los_Angeles',^M
> 225+    'timezone_type' => 2,^M
> 226+    'timezone' => 'PDT',^M
> 225-    'timezone_type' => 3,^M
> 226-    'timezone' => 'America/Los_Angeles',^M
> 233+    'timezone_type' => 2,^M
> 234+    'timezone' => 'PDT',^M
> 233-    'timezone_type' => 3,^M
> 234-    'timezone' => 'America/Los_Angeles',^M
> 241+    'timezone_type' => 2,^M
> 242+    'timezone' => 'PDT',^M
> 241-    'timezone_type' => 3,^M
> 242-    'timezone' => 'America/Los_Angeles',
>
>
> Could anybody who has this test passing tell me what ICU version are you
> testing with?
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
>
>
I've forked this one into ext/intl/tests/dateformat_format_variant3.phpt
and adjusted the output for 52.1. The variant 2 is worky with at least ICI
51.2, i've added the corresponding condition to the skipif. Looks like
this change happens somewhere between ICU 51.2 and 52.

Cheers

Anatol