Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73618
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5341F12B.5070907@sugarcrm.com>
References: <5341F12B.5070907@sugarcrm.com>
Date: Mon, 7 Apr 2014 01:49:19 -0400
Message-ID: <CAL+t6cEnmSY59W2Hf5MM0EHrqyQA8NCB8QjsCmMRPnMzd17uJQ@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b66f9cbc02ace04f66d6d24
Subject: Re: [PHP-DEV] Pull 638 - floats in user-defined comparisons
From: theanomaly.is@gmail.com (Sherif Ramadan)

--047d7b66f9cbc02ace04f66d6d24
Content-Type: text/plain; charset=ISO-8859-1

On Sun, Apr 6, 2014 at 8:28 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> I looked at pull 638 and it looks OK code-wise. Are there any objections
> still to merging it? It changes behavior slightly and the warning in the
> docs no longer applies, but I think new behavior is actually better than
> the old one as for most doubles between -1 and 1 we do not get random
> sorting behavior anymore.
>


I'm not entirely sure if this is such a good idea, but I also can't say
it's a bad idea.

It'll likely break someone's code out there that relies on the existing
behavior (for some strange reason). I thought it was actually a better idea
to document the behavior. Which is why I added the caution in the manual.
It's simpler and removes the ambiguity about what's expected from the
callback.

This PR just adds some complexity for little more than added magic. I'm not
a fan of magic in general, but I can see how most users think of magic as
being useful... That is of course, until it comes back to bite them.

Not opposed to merging this, but just my 2 cents.

--047d7b66f9cbc02ace04f66d6d24--