Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73617 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97998 invoked from network); 7 Apr 2014 00:28:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Apr 2014 00:28:32 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.123 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.123 smtp123.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.123] ([108.166.43.123:54466] helo=smtp123.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CB/60-29954-E21F1435 for ; Sun, 06 Apr 2014 20:28:31 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp8.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 583811A022D for ; Sun, 6 Apr 2014 20:28:28 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp8.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 224B31A01A2 for ; Sun, 6 Apr 2014 20:28:28 -0400 (EDT) Message-ID: <5341F12B.5070907@sugarcrm.com> Date: Sun, 06 Apr 2014 17:28:27 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Pull 638 - floats in user-defined comparisons From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! I looked at pull 638 and it looks OK code-wise. Are there any objections still to merging it? It changes behavior slightly and the warning in the docs no longer applies, but I think new behavior is actually better than the old one as for most doubles between -1 and 1 we do not get random sorting behavior anymore. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227