Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73596
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPhkiZxcWa+bwMOOMcjnTThY_CTRK5r5K7HWCFqHhKVUbqN7dA@mail.gmail.com>
References: <CAMUwpuSVE4iMA86bxXUnvYLonJ3xmDZ_QSzM38eNvJibxcv6Xw@mail.gmail.com>
 <CAGa2bXYO6s6sQo0UkuRSaSciU1XVCHhWqc5MHCDL1H15ChZ65Q@mail.gmail.com>
 <CAMUwpuQePpm3FLY27ptvPyBU=kndK805D8sRr5N3GSoTQiiGxw@mail.gmail.com>
 <CAPhkiZy=y7AAfwtNPgPgfEWvLyv+aOnU=Yi_XKTYsszB7dS74g@mail.gmail.com>
 <CAGa2bXZJN72Z+L24NxVNT0A0sdojr8tJ4E5TPjYUTnjvSWkPig@mail.gmail.com>
 <CAPhkiZzBOM_jAm_tz2YKpj_ExJRUuP8y2dHBy4tm3+6KeHNiCQ@mail.gmail.com>
 <CAGa2bXaau5peLX=dh+6OUtOxKdYsHQzzdJktiXmDqb5UmXB96A@mail.gmail.com>
 <CAPhkiZy_1mQ4WGz1CiKiiC32i_oOVyfkTu===QZjV=UtWY6mKA@mail.gmail.com>
 <CAGa2bXbHomZmh91wk-5=LHG7S2FSbxTUnD+M=E9756WxFwYmHg@mail.gmail.com> <CAPhkiZxcWa+bwMOOMcjnTThY_CTRK5r5K7HWCFqHhKVUbqN7dA@mail.gmail.com>
Date: Sat, 5 Apr 2014 07:31:37 +0900
Message-ID: <CAGa2bXZ_kEYidfmYRde8HuXtfZzjtSLyWRxVVj2NyUZZGz7N_A@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: Julien Pauli <jpauli@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3474c159b2004f63f17f0
Subject: Re: session_reset() and session_abort() to send errors
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c3474c159b2004f63f17f0
Content-Type: text/plain; charset=UTF-8

Hi Andrey,

On Fri, Apr 4, 2014 at 7:07 PM, Andrey Andreev <narf@devilix.net> wrote:

> On Fri, Apr 4, 2014 at 12:48 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > Hi Andrey,
> >
> > On Tue, Apr 1, 2014 at 6:20 PM, Andrey Andreev <narf@devilix.net> wrote:
> >>
> >> >> Well, I just re-checked it and does indeed just call
> >> >> php_session_initialize(), so what's the point? Shorthand for
> >> >> session_abort() && session_start() ?
> >> >
> >> >
> >> > Yes, it's an API for it.
> >> > It's more efficient than user land functions as it requires needless
> >> > close and open (and initialization required to open).
> >>
> >> I'm confused now, does it call open() or does it not?
> >> If it doesn't - it's unsafe.
> >
> >
> > It's safe as long as handler locks data during read/write.
> > Example is memcached save handler with unlocked session.
>
> I had something other in mind and you didn't really answer my
> question, but ... there you have it - it can be unsafe even by your
> own words. :)
>

Regarding to safety of session data management, session management is _not_
safe anyway. Locked session does not guarantee data consistency due to
nature of HTTP session management. Locked session provides a litter better
consistency. That's all and no more than that. i.e. It's false sense of
safety.

That said better is better. That's the reason why I'm proposing various
_better_
way of management than now.

>> If it does - it's unclear, redundant and optimizes by silently
> >> discarding already open resources (without properly closing them).
> >>
> >> Either way, I like efficiency but I also see it as flawed.
> >
> >
> > Save handler may lock/unlock session data. There is no standardized
> > way for it.
> >
> > Since there would not be lock option for session manager, I don't mind
> > removing it. There is not much point to have it without lock option for
> > session manager. I would like to have session_gc() than session_reset().
>
> This sounds a bit like you're proposing some kind of a trade
> agreement. When you put it that way, I'd also rather have session_gc()
> instead of session_reset(), but that's not the point. My initial
> argument was that these features need to be brainstormed here on
> internals and there was no discussion about them at all.


It's not trade. session_gc() is mandatory and I'll add it anyway :)
Periodic GC is much better way than probability based GC. There must
be API for it. I think there wouldn't be argument for this.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c3474c159b2004f63f17f0--