Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73495 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14067 invoked from network); 1 Apr 2014 01:00:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Apr 2014 01:00:33 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.50 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.50 mail-la0-f50.google.com Received: from [209.85.215.50] ([209.85.215.50:51901] helo=mail-la0-f50.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E9/50-12216-FAF0A335 for ; Mon, 31 Mar 2014 20:00:32 -0500 Received: by mail-la0-f50.google.com with SMTP id pv20so2139848lab.37 for ; Mon, 31 Mar 2014 18:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=bGCPrhA6V+RBc2Z3YJp4GFhNAvEqEhgwltsqMT52NMw=; b=pk2kgclRbuRBr0i9bXAmm82jCHIyJOaVvCWdVxsL4cHNWVpzs1JJPk6cs29arDhJcu N4mmz+SBWb6hpWCRzrEOrfUwQ0YuZdgsg7O3YoopwS39nD1Y+c5NCgL086493aWB29wJ lJovWclnGqJeAnzkZBzpndbzCoNqgTfYNN10tSqpXwkMcDIjCVmZ5R3a1rCapa05Ucea /3Lz6dLMt07jodqoaQUd38ELKenVmYykKZ6422b+4+Vd3IeJKBcXaQ8QX2l1akF6nTe1 gC6Tobtoft+uddzyhK1RdVPG8tL9W9teJIb342o0WpdnL+GUpfo/TUFplSHkwhT2hBhm g2mA== X-Received: by 10.112.106.40 with SMTP id gr8mr19624292lbb.0.1396314029192; Mon, 31 Mar 2014 18:00:29 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.205.73 with HTTP; Mon, 31 Mar 2014 17:59:48 -0700 (PDT) In-Reply-To: References: Date: Tue, 1 Apr 2014 09:59:48 +0900 X-Google-Sender-Auth: 4QIVT1MmIJ388ITEif_z61UOSLY Message-ID: To: Andrey Andreev Cc: Julien Pauli , PHP Internals Content-Type: multipart/alternative; boundary=001a1134dec4b4798304f5f0b166 Subject: Re: session_reset() and session_abort() to send errors From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a1134dec4b4798304f5f0b166 Content-Type: text/plain; charset=UTF-8 Hi Andrey, On Fri, Mar 28, 2014 at 6:41 PM, Andrey Andreev wrote: > On Fri, Mar 28, 2014 at 8:54 AM, Yasuo Ohgaki wrote: > > Hi Andrey, > > > > On Wed, Mar 26, 2014 at 1:06 AM, Andrey Andreev > wrote: > >> > >> From what I understand, session_reset() not only discards changes to > >> $_SESSION and not just re-reads the data, but re-initializes the whole > >> session. This includes calls to open(), read(), which include opening > >> file pointers, setting locks, checking session ID validity, etc. I > >> don't know how safe that is to do internally, but with a userland > >> session handler, it means discarding previously open connections/file > >> pointers, locks and whoever knows what else a developer might've > >> cached, assuming that open(), read() would only be called once. > >> It would've also been better IMO if the function was called > >> session_restart() instead, because of the above-described behavior. > > > > > > It's safe. Don't worry. > > As always, I prefer better names. > > Well, I just re-checked it and does indeed just call > php_session_initialize(), so what's the point? Shorthand for > session_abort() && session_start() ? Yes, it's an API for it. It's more efficient than user land functions as it requires needless close and open (and initialization required to open). Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a1134dec4b4798304f5f0b166--