Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73467
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.160.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbHCkFNx1U0e+Cuv7ixPonRZBmnXwvU8WUgu=Z=R=YMsA@mail.gmail.com>
References: <CAPhkiZyFHshFc56UEHiDFK9k801ztno+xoS82Yf6qAcwiRPg1A@mail.gmail.com>
	<010e01cf4788$05f3c5a0$11db50e0$@devtemple.com>
	<CAPhkiZx8DuDPfks-RNNNunHsjso-9KuwRBor8TjRaK3E10qUiA@mail.gmail.com>
	<01c801cf47c0$59acbf20$0d063d60$@devtemple.com>
	<CAPhkiZwNywUi_LjOcTmB_aDONHcmpHFtExW6h+S4yYHf4ypitQ@mail.gmail.com>
	<CAPhkiZwPBoN+Y+gyTXZB68HTfYkA5eZ-yn_=2FMvir+oFza5TQ@mail.gmail.com>
	<CAMUwpuRH-cQ9fasUyOft5C7JRi5N=6szwDV5inf+wNi-eAC2iA@mail.gmail.com>
	<CAPhkiZwLk4Kjh732WAkEF+U6VyMVEz5fzi4SNVhaQK9-Rdbnew@mail.gmail.com>
	<CAGa2bXYpS6HA2LHd3C8BQ+OK0nsDYEwCfF=K7_-A0tWeOqp3vA@mail.gmail.com>
	<CAPhkiZyWJ_602JzpP9p-3T_ABPDvENE=VriK8RSLPqNNw=zUWw@mail.gmail.com>
	<CAGa2bXbHCkFNx1U0e+Cuv7ixPonRZBmnXwvU8WUgu=Z=R=YMsA@mail.gmail.com>
Date: Fri, 28 Mar 2014 11:46:37 +0200
Message-ID: <CAPhkiZwnugyOWWsPghQY0L+Q_VMuwf1vHnjuZyAGUe7=Mox-ng@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Julien Pauli <jpauli@php.net>, Bill Salak <bill@devtemple.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] session_start(), read_only, lazy_write; Take 2
From: narf@devilix.net (Andrey Andreev)

Hi,

>> >> Btw, another argument in merging updateTimestamp() into write() is
>> >> that userland implementations of it up until now have only been
>> >> possible by altering write(), so at least some users should be more
>> >> familiar with that approach.
>> >
>> >
>> > Component only does its jobs with good implementation.
>> > Session module consists of session manager, session save handler and
>> > session
>> > serializer.
>> >
>> > Session manager should manage how it works.
>> > Session save handler should save/retrieve session data only.
>> > Session serializer should serialize/unserialize data only.
>> >
>> > It breaks this design with your suggestion.
>> > So letting save handler do the manager's job is not good. IMO.
>>
>> I don't understand how that's breaking any kind of design. Could you
>> elaborate?
>
>
> Manager should manage how session behaves, not save handlers.
> It's basic principle of modular design.

I still don't get it ... the session manager has to call either
write() or updateTimestamp() and both of these are part of the session
handler. Merging them into one solves the API design and BC issues, I
don't see how it breaks any principle. They can still be split to two
methods in PHP6, but for the time being, using write() for both
purposes IMO solves way more problems than sticking to this design
principle you're talking about.

Cheers,
Andrey.