Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73466
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.213.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZJN72Z+L24NxVNT0A0sdojr8tJ4E5TPjYUTnjvSWkPig@mail.gmail.com>
References: <CAMUwpuSVE4iMA86bxXUnvYLonJ3xmDZ_QSzM38eNvJibxcv6Xw@mail.gmail.com>
	<CAGa2bXYO6s6sQo0UkuRSaSciU1XVCHhWqc5MHCDL1H15ChZ65Q@mail.gmail.com>
	<CAMUwpuQePpm3FLY27ptvPyBU=kndK805D8sRr5N3GSoTQiiGxw@mail.gmail.com>
	<CAPhkiZy=y7AAfwtNPgPgfEWvLyv+aOnU=Yi_XKTYsszB7dS74g@mail.gmail.com>
	<CAGa2bXZJN72Z+L24NxVNT0A0sdojr8tJ4E5TPjYUTnjvSWkPig@mail.gmail.com>
Date: Fri, 28 Mar 2014 11:41:05 +0200
Message-ID: <CAPhkiZzBOM_jAm_tz2YKpj_ExJRUuP8y2dHBy4tm3+6KeHNiCQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Julien Pauli <jpauli@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: session_reset() and session_abort() to send errors
From: narf@devilix.net (Andrey Andreev)

Hi,

On Fri, Mar 28, 2014 at 8:54 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Andrey,
>
> On Wed, Mar 26, 2014 at 1:06 AM, Andrey Andreev <narf@devilix.net> wrote:
>>
>> From what I understand, session_reset() not only discards changes to
>> $_SESSION and not just re-reads the data, but re-initializes the whole
>> session. This includes calls to open(), read(), which include opening
>> file pointers, setting locks, checking session ID validity, etc. I
>> don't know how safe that is to do internally, but with a userland
>> session handler, it means discarding previously open connections/file
>> pointers, locks and whoever knows what else a developer might've
>> cached, assuming that open(), read() would only be called once.
>> It would've also been better IMO if the function was called
>> session_restart() instead, because of the above-described behavior.
>
>
> It's safe. Don't worry.
> As always, I prefer better names.

Well, I just re-checked it and does indeed just call
php_session_initialize(), so what's the point? Shorthand for
session_abort() && session_start() ?

Cheers,
Andrey.