Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73462 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 49508 invoked from network); 28 Mar 2014 09:15:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Mar 2014 09:15:45 -0000 Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.181 as permitted sender) X-PHP-List-Original-Sender: julienpauli@gmail.com X-Host-Fingerprint: 209.85.220.181 mail-vc0-f181.google.com Received: from [209.85.220.181] ([209.85.220.181:60472] helo=mail-vc0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EA/B2-31219-0CD35335 for ; Fri, 28 Mar 2014 04:15:44 -0500 Received: by mail-vc0-f181.google.com with SMTP id id10so5690995vcb.12 for ; Fri, 28 Mar 2014 02:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=I4Yua5IDwDc2GdUTnyXdQI9jatR0CQQuO9vjZpquE/k=; b=TEU2ErD/U9wH8OhB/pAprU/ND9/wYFKN2ZNNKDhP4izaUghDqCNXtQ9mZeNi6kNGJR hO2e7lOBs7h4TIzaVhXB54TJefqaeTWVUYcuityzWOgVv5IFt49PxETjQtBcDvTzZMKY OyDU6A0er/GGB5NrRtrqmGslpy2O3jdYXoapQz+unBF5XPzk0lWf1BV7sgeq+rUe1e+O M9SaxRaPVo+nHJmY4vLzp8JGSI+9TqETPIsn2rXOHfa9D28AmR8PC/ebuMp+bnSZwaXX VylmoUa7ruZK0VtoP4ZIeyOpKfqhe93o+8KVcgekS0Jrzh3oMfw+TMfuiYPr2hDzxUVL y87Q== X-Received: by 10.220.12.66 with SMTP id w2mr6050572vcw.15.1395998141708; Fri, 28 Mar 2014 02:15:41 -0700 (PDT) MIME-Version: 1.0 Sender: julienpauli@gmail.com Received: by 10.220.81.68 with HTTP; Fri, 28 Mar 2014 02:15:01 -0700 (PDT) In-Reply-To: References: <010e01cf4788$05f3c5a0$11db50e0$@devtemple.com> <01c801cf47c0$59acbf20$0d063d60$@devtemple.com> Date: Fri, 28 Mar 2014 10:15:01 +0100 X-Google-Sender-Auth: Yq8Rn-mRufYxonC9apo9A8_TFWg Message-ID: To: Yasuo Ohgaki Cc: Andrey Andreev , Bill Salak , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a11c3150057fef104f5a7253f Subject: Re: [PHP-DEV] [RFC] session_start(), read_only, lazy_write; Take 2 From: jpauli@php.net (Julien Pauli) --001a11c3150057fef104f5a7253f Content-Type: text/plain; charset=ISO-8859-1 On Fri, Mar 28, 2014 at 8:34 AM, Yasuo Ohgaki wrote: > Hi Julien, > > On Wed, Mar 26, 2014 at 7:29 PM, Julien Pauli wrote: > >> > In order to avoid further arguments about whether a separate function >> > for read-and-close is better or not, I've added an alternative >> > proposal - to rename the option to 'read_close' or 'read_and_close'. >> > After all, the most important thing is that it's not 'read_only'. >> >> >> I agree "read_and_close" is much better discribing what it really does , >> so >> I prefer it. > > > I'm not sure if it's good to have "and" or not, but I'm OK with or without > "and". > > Should I change it now? > I mean in my github repo. > I haven't committed the RFC patch yet. > Yes please. Also, for error raising, I saw your github discussion. We already raise errors in session functions when the session state is not the good one at some point. I suggest we do it as well for new session functions that's been introduced : session_reset() and session_abort(). Leave session_write_close() as it is. Thx. Julien --001a11c3150057fef104f5a7253f--