Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73457 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37712 invoked from network); 28 Mar 2014 06:55:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Mar 2014 06:55:05 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.43 mail-la0-f43.google.com Received: from [209.85.215.43] ([209.85.215.43:60101] helo=mail-la0-f43.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 07/A0-31219-9CC15335 for ; Fri, 28 Mar 2014 01:55:05 -0500 Received: by mail-la0-f43.google.com with SMTP id e16so3393991lan.16 for ; Thu, 27 Mar 2014 23:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=Ozrz4NxVL3aEd8mXZC66p0wgE2fEfNLIzndws9FSvbc=; b=J7kxqecm9Dd4D7fl5pKB0J9dQ2BMYK74tEwfMN+jbJhQ7emiTu71WPTCE0xyZoBVSc ZQCwIRn9DKHxkMk/5G3I9oxXmme6F/XIBPZcfoFzMgbj3l1DXpEwerzvvtnc0iwOI3/4 isddOwucTF0MnusiHxuk8+iP9hTYIgZkaIbF6bMn07PsGmWMS3CunbxoroqQAb3VDtrC tJtGlw75JnA0UHGjvzEqLTeCrrETRte8ZO/6k6e2Q4uib/k4HFzX+FZUJ8g6/z59lRPc VcOj6Mrx8yaePYiT5CP6+WfQ+MMvYpxrKfjkQK479SWS4bT7fQKosaaNlaNOgOMjO7si jKVA== X-Received: by 10.152.42.196 with SMTP id q4mr4392810lal.14.1395989702117; Thu, 27 Mar 2014 23:55:02 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.205.73 with HTTP; Thu, 27 Mar 2014 23:54:22 -0700 (PDT) In-Reply-To: References: Date: Fri, 28 Mar 2014 15:54:22 +0900 X-Google-Sender-Auth: jXjXH7fZE10R-jeXDfqIVow26wY Message-ID: To: Andrey Andreev Cc: Julien Pauli , PHP Internals Content-Type: multipart/alternative; boundary=001a11c34e8e4e0c2a04f5a52e19 Subject: Re: session_reset() and session_abort() to send errors From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11c34e8e4e0c2a04f5a52e19 Content-Type: text/plain; charset=UTF-8 Hi Andrey, On Wed, Mar 26, 2014 at 1:06 AM, Andrey Andreev wrote: > From what I understand, session_reset() not only discards changes to > $_SESSION and not just re-reads the data, but re-initializes the whole > session. This includes calls to open(), read(), which include opening > file pointers, setting locks, checking session ID validity, etc. I > don't know how safe that is to do internally, but with a userland > session handler, it means discarding previously open connections/file > pointers, locks and whoever knows what else a developer might've > cached, assuming that open(), read() would only be called once. > It would've also been better IMO if the function was called > session_restart() instead, because of the above-described behavior. > It's safe. Don't worry. As always, I prefer better names. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11c34e8e4e0c2a04f5a52e19--