Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73454
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.213.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYLLw=CC54ceJe76n+tCBz-CawR3jR=A4Cx=gAoL91-tA@mail.gmail.com>
References: <CAMUwpuSVE4iMA86bxXUnvYLonJ3xmDZ_QSzM38eNvJibxcv6Xw@mail.gmail.com>
	<CAGa2bXYO6s6sQo0UkuRSaSciU1XVCHhWqc5MHCDL1H15ChZ65Q@mail.gmail.com>
	<CAMUwpuQePpm3FLY27ptvPyBU=kndK805D8sRr5N3GSoTQiiGxw@mail.gmail.com>
	<CAPhkiZy=y7AAfwtNPgPgfEWvLyv+aOnU=Yi_XKTYsszB7dS74g@mail.gmail.com>
	<CAMUwpuQ1NodZ+GXdT+3zFWQXbWQMBPnzB35mqLp6ghbwAfLhBA@mail.gmail.com>
	<CAGa2bXYLLw=CC54ceJe76n+tCBz-CawR3jR=A4Cx=gAoL91-tA@mail.gmail.com>
Date: Thu, 27 Mar 2014 14:05:57 +0200
Message-ID: <CAPhkiZze7NoetcmzUiwRXHCk9s=epRVrm2Nc57tbLSwZCCRSKg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Julien Pauli <jpauli@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: session_reset() and session_abort() to send errors
From: narf@devilix.net (Andrey Andreev)

Hi,

> This function is useful for session save handlers that do not lock
> session data. Example is memcached. This function could be used
> re-read session data to mitigate over written session data with unlock
> session data.
>
> Andrey, just because you don't think of usage, it does not mean it does not
> mean unneeded or not useful. You are better to ask the reason behind why
> first.
> Good library should have defined API for specific tasks, too. You also has
> misunderstanding about why delayed deletion for session_regenerate_id()
> is mandatory.

Yasuo ... There's no misunderstanding, I just have a disagreement with
you about that issue and I'm tired of arguing over that. Let's just
keep session_regenerate_id() in it's own thread, ok?
But speaking of mandatory: locks are mandatory, so how are non-locking
handlers an argument in all of this?

Also, I didn't just question if there's a use case, I'm questioning if
it is safe to use session_reset() at all. Re-reading doesn't imply
discarding currently open resources and complerely re-initializing the
session and from what I see - that's exactly what the function does,
or am I missing something?

Cheers,
Andrey.