Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73452 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72352 invoked from network); 27 Mar 2014 10:39:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Mar 2014 10:39:03 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.180 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.180 mail-lb0-f180.google.com Received: from [209.85.217.180] ([209.85.217.180:62797] helo=mail-lb0-f180.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/C0-64394-3CFF3335 for ; Thu, 27 Mar 2014 05:39:00 -0500 Received: by mail-lb0-f180.google.com with SMTP id 10so2467912lbg.11 for ; Thu, 27 Mar 2014 03:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=I28cki9bg+PocnCGHF0wE8TfIDs1iJTYeYblbrTto6k=; b=Td7SQNw9vofWbkiBMp/P4GfIEr8HWxbVeiIktgSshEQ/AEZdo7CByMhfE5jFUvETv5 dW/N185LDa+opzEIiJgANplzSlD+VAvGUkQXSeyjkWMmsKmjWnDUoFwTJN/m0J1opJ0v 0ezM24f8a+hqB+SneV19hkFDSko4UE7PfOtE+IzAMvwzOgyDHUMBs7Dixl8aNc+kVn7L e2ykytHxx4AA3f8fUml5+7Q/nPclL1f7hphqR145D7HctSz3HfTDPTlwamX9aeYVLb2l jNi8+dE1kkwWrTJunEsXLtyHdA1F6otJIedLo5oH6qKcatnp91SuaO2yOoIT3PjZS/j4 EdXw== X-Received: by 10.152.172.103 with SMTP id bb7mr176429lac.49.1395916737195; Thu, 27 Mar 2014 03:38:57 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.205.73 with HTTP; Thu, 27 Mar 2014 03:38:16 -0700 (PDT) In-Reply-To: References: Date: Thu, 27 Mar 2014 19:38:16 +0900 X-Google-Sender-Auth: e3NGsTQluena7dWEq3MiJUXOOkQ Message-ID: To: Julien Pauli Cc: Andrey Andreev , PHP Internals Content-Type: multipart/alternative; boundary=001a113814c441b57f04f594319c Subject: Re: session_reset() and session_abort() to send errors From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a113814c441b57f04f594319c Content-Type: text/plain; charset=UTF-8 Hi all, On Wed, Mar 26, 2014 at 6:57 PM, Julien Pauli wrote: > Yup, I agree that I dont really see a use case for session_reset(). > The implementation looks strange. > > Yasuo, could you clarify please ? > This function is useful for session save handlers that do not lock session data. Example is memcached. This function could be used re-read session data to mitigate over written session data with unlock session data. Andrey, just because you don't think of usage, it does not mean it does not mean unneeded or not useful. You are better to ask the reason behind why first. Good library should have defined API for specific tasks, too. You also has misunderstanding about why delayed deletion for session_regenerate_id() is mandatory. BTW, raising errors for invalid calls has issues, so I send PR to discuss. https://github.com/php/php-src/pull/634 Regards, P.S. If I should choose to remove this or session_gc(), I choose this because session_gc() is mandatory API for decent session manager. -- Yasuo Ohgaki yohgaki@ohgaki.net --001a113814c441b57f04f594319c--