Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73444
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.160.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAMUwpuRH-cQ9fasUyOft5C7JRi5N=6szwDV5inf+wNi-eAC2iA@mail.gmail.com>
References: <CAPhkiZyFHshFc56UEHiDFK9k801ztno+xoS82Yf6qAcwiRPg1A@mail.gmail.com>
	<010e01cf4788$05f3c5a0$11db50e0$@devtemple.com>
	<CAPhkiZx8DuDPfks-RNNNunHsjso-9KuwRBor8TjRaK3E10qUiA@mail.gmail.com>
	<01c801cf47c0$59acbf20$0d063d60$@devtemple.com>
	<CAPhkiZwNywUi_LjOcTmB_aDONHcmpHFtExW6h+S4yYHf4ypitQ@mail.gmail.com>
	<CAPhkiZwPBoN+Y+gyTXZB68HTfYkA5eZ-yn_=2FMvir+oFza5TQ@mail.gmail.com>
	<CAMUwpuRH-cQ9fasUyOft5C7JRi5N=6szwDV5inf+wNi-eAC2iA@mail.gmail.com>
Date: Wed, 26 Mar 2014 13:15:44 +0200
Message-ID: <CAPhkiZwLk4Kjh732WAkEF+U6VyMVEz5fzi4SNVhaQK9-Rdbnew@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: Bill Salak <bill@devtemple.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] session_start(), read_only, lazy_write; Take 2
From: narf@devilix.net (Andrey Andreev)

Hi,

On Wed, Mar 26, 2014 at 12:29 PM, Julien Pauli <jpauli@php.net> wrote:
> For non BC changes etc.. , please, consider that you'll have a big time for
> rethinking the whole session module for PHP6 if you want to (and I think
> I'll be part of deep discussions here)
> So don't bother too much in searching solutions for introducting new
> concepts in PHP5.X session module while keeping BC. Keep all those for PHP6.

Of course, I've got more ideas for PHP6, but what I'm targeting here
are already voted features that could've been designed in a better
way.

Btw, another argument in merging updateTimestamp() into write() is
that userland implementations of it up until now have only been
possible by altering write(), so at least some users should be more
familiar with that approach. For example:

class MySessionHandler extends SessionHandler {

    public $fingerprint;

    public function read($session_id)
    {
        $session_data = parent::read($session_id);
        $this->fingerprint = md5($session_data);
        return $session_data;
    }

    public function write($session_id, $session_data)
    {
        if ($this->fingerprint === md5($session_data)
        {
            return touch(ini_get('session.save_path').'/sess_'.$session_id);
        }

        return parent::write($session_id, $session_data);
    }

Cheers,
Andrey.