Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73441
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2F+by6oWRpWMkt8eeno72KqR6HURJ=Oc6DOpy6vqy7H_w@mail.gmail.com>
References: <CAHMUw2EeYA3m4QnRtLYm1PRa3taGiS8Sx5GxdN==ZYTQoFV=vQ@mail.gmail.com>
	<532A3E88.20202@sugarcrm.com>
	<ECAD39ED-2A1D-4B54-80D5-4CB4FBA71364@gmail.com>
	<532A418A.8020607@sugarcrm.com>
	<CACQesk74e3=FNd4KgC4XDHXiq97yk8KXRXAvV3tqRWOzFwN_pw@mail.gmail.com>
	<532B4A1B.5090503@sugarcrm.com>
	<CACQesk5W8H+NuZVeUprDOMK26szTQYtHFeT5XoWwYXLCb-8=Vw@mail.gmail.com>
	<532B6581.6030801@sugarcrm.com>
	<CAHMUw2Ff0cQjudC0tdJ+6y8ybsuFQ9qN6kdZ0kbKbfAcQG3jWA@mail.gmail.com>
	<532B91AF.7090804@sugarcrm.com>
	<CAHMUw2EJMPsAuW2W1J3OWb05yAa1iXfzP5ebJxkKzO1Skj+DVg@mail.gmail.com>
	<CAHMUw2FNswaNZ50jjGHu__=pBcZp+ZV2OK69u6D-xODzvgpMsw@mail.gmail.com>
	<5330F929.3080000@sugarcrm.com>
	<CAHMUw2GFkGCJeLAet3e-NoYevchD3ab4SvTc4Gd6GD7uceakXw@mail.gmail.com>
	<5330FDF7.1040904@sugarcrm.com>
	<CAHMUw2F4CGwxzkUuvuDs-oGbC10Rr2cJOBOwnL=mJQ8b_TWtHg@mail.gmail.com>
	<CAFMT4NoG31pJo8u074Sqcm1h7j0NzEzPZBAcKHMzDrX6zeYBrQ@mail.gmail.com>
	<CAHMUw2F+by6oWRpWMkt8eeno72KqR6HURJ=Oc6DOpy6vqy7H_w@mail.gmail.com>
Date: Wed, 26 Mar 2014 12:56:06 +0800
Message-ID: <CAHMUw2EyOJVCpSRA9Vbzj_tXtK58+YC2VYKQUkrrwfLBh4t0Nw@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, Etienne Kneuss <colder@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec50fdff354f6c304f57b4975
Subject: Re: [PHP-DEV] Merge PR 621
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--bcaec50fdff354f6c304f57b4975
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Mar 26, 2014 at 12:14 PM, Tjerk Meesters
<tjerk.meesters@gmail.com>wrote:

> Hi Levi,
>
> On Tue, Mar 25, 2014 at 9:51 PM, Levi Morrison <morrison.levi@gmail.com>wrote:
>
>> In a similar vein have we checked `offsetSet`? It seems `offsetSet` is
>> not called with `+=`; I am not sure if this is intended; see
>> https://bugs.php.net/bug.php?id=66641
>>
>
> This is due to how binary assignment is applied to properties vs arrays:
>
> http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_execute.h#31979
>
> The workaround here is to disable the `get_property_ptr_ptr` inside
> `spl_array.c`, like this:
>
> https://gist.github.com/datibbaw/703597322ad411287461
>

The test suite proved me wrong about this, as bug65328.phpt fails and
causes some memory leaks when applied; some tweaks may be required or an
altogether different approach :)


>
>
> Not sure if everyone will agree to that change, but it's one way to fix
> the bug other than changing the API itself :)
>
>
>>
>>
>> On Tue, Mar 25, 2014 at 4:38 AM, Tjerk Meesters <tjerk.meesters@gmail.com
>> > wrote:
>>
>>> Hi,
>>>
>>>
>>> On Tue, Mar 25, 2014 at 11:54 AM, Stas Malyshev <smalyshev@sugarcrm.com
>>> >wrote:
>>>
>>> > Hi!
>>> >
>>> > > It's my understanding that you should (have to) only call "get" if
>>> you
>>> > > know that the offset exists.
>>> >
>>> > Yes, you are right. I'd still add some example that changes the keys to
>>> > the tests to ensure all cases are covered properly. But looks like it
>>> > works OK in all cases I could think of.
>>> >
>>>
>>> I've updated the test case with such an example.
>>>
>>> PHP-5.6 and master have been updated.
>>>
>>>
>>>
>>> > --
>>> > Stanislav Malyshev, Software Architect
>>> > SugarCRM: http://www.sugarcrm.com/
>>> > (408)454-6900 ext. 227
>>> >
>>>
>>>
>>>
>>> --
>>> --
>>> Tjerk
>>>
>>
>>
>
>
> --
> --
> Tjerk
>



-- 
--
Tjerk

--bcaec50fdff354f6c304f57b4975--