Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73440 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87273 invoked from network); 26 Mar 2014 04:14:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Mar 2014 04:14:59 -0000 Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.182 as permitted sender) X-PHP-List-Original-Sender: tjerk.meesters@gmail.com X-Host-Fingerprint: 209.85.220.182 mail-vc0-f182.google.com Received: from [209.85.220.182] ([209.85.220.182:38872] helo=mail-vc0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F1/32-07356-24452335 for ; Tue, 25 Mar 2014 23:14:59 -0500 Received: by mail-vc0-f182.google.com with SMTP id ks9so1776834vcb.13 for ; Tue, 25 Mar 2014 21:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7QL3vINIeUv9cT1d7rT3DlNTgPwMNLolHXTG+e1AoTQ=; b=jZ5HwVsqWW59R4o0nG0WBtQVjjsctGpcPzT6HP8jPzsUdbVw4kw4AbunX5cUS7N9H8 FZq7N7IYrlmcw2z/FpQYjCA7HAkENKWBHioWrxiwpBPndH5ZKuOuMzb64kFVS/1diHMW aAYs5eU5qCViIMXhQXiWKNNPRKfsKSizYqKdVlpTnXB7AGEWMD/dDgW1qdLS0C0DSd6/ GReVmzpz7E2qF1lfyEw/8nTZN0mjAJWikqlzScBDjLk3NyK7dAAYlNlOXJBUn1fUewfp bdqh63c7OoAaUF6xztYNKjU3QIWi449s5a88t8OpzB+8Hm5DKRKi60D6mSD4hBQtu90A SQGw== MIME-Version: 1.0 X-Received: by 10.58.202.106 with SMTP id kh10mr63537vec.31.1395807295548; Tue, 25 Mar 2014 21:14:55 -0700 (PDT) Received: by 10.58.55.131 with HTTP; Tue, 25 Mar 2014 21:14:55 -0700 (PDT) In-Reply-To: References: <532A3E88.20202@sugarcrm.com> <532A418A.8020607@sugarcrm.com> <532B4A1B.5090503@sugarcrm.com> <532B6581.6030801@sugarcrm.com> <532B91AF.7090804@sugarcrm.com> <5330F929.3080000@sugarcrm.com> <5330FDF7.1040904@sugarcrm.com> Date: Wed, 26 Mar 2014 12:14:55 +0800 Message-ID: To: Levi Morrison Cc: Stas Malyshev , Etienne Kneuss , PHP Internals Content-Type: multipart/alternative; boundary=047d7bdc945e06b25604f57ab694 Subject: Re: [PHP-DEV] Merge PR 621 From: tjerk.meesters@gmail.com (Tjerk Meesters) --047d7bdc945e06b25604f57ab694 Content-Type: text/plain; charset=ISO-8859-1 Hi Levi, On Tue, Mar 25, 2014 at 9:51 PM, Levi Morrison wrote: > In a similar vein have we checked `offsetSet`? It seems `offsetSet` is not > called with `+=`; I am not sure if this is intended; see > https://bugs.php.net/bug.php?id=66641 > This is due to how binary assignment is applied to properties vs arrays: http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_execute.h#31979 The workaround here is to disable the `get_property_ptr_ptr` inside `spl_array.c`, like this: https://gist.github.com/datibbaw/703597322ad411287461 Not sure if everyone will agree to that change, but it's one way to fix the bug other than changing the API itself :) > > > On Tue, Mar 25, 2014 at 4:38 AM, Tjerk Meesters wrote: > >> Hi, >> >> >> On Tue, Mar 25, 2014 at 11:54 AM, Stas Malyshev > >wrote: >> >> > Hi! >> > >> > > It's my understanding that you should (have to) only call "get" if you >> > > know that the offset exists. >> > >> > Yes, you are right. I'd still add some example that changes the keys to >> > the tests to ensure all cases are covered properly. But looks like it >> > works OK in all cases I could think of. >> > >> >> I've updated the test case with such an example. >> >> PHP-5.6 and master have been updated. >> >> >> >> > -- >> > Stanislav Malyshev, Software Architect >> > SugarCRM: http://www.sugarcrm.com/ >> > (408)454-6900 ext. 227 >> > >> >> >> >> -- >> -- >> Tjerk >> > > -- -- Tjerk --047d7bdc945e06b25604f57ab694--