Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73426 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 38398 invoked from network); 25 Mar 2014 13:51:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Mar 2014 13:51:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=morrison.levi@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=morrison.levi@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.54 as permitted sender) X-PHP-List-Original-Sender: morrison.levi@gmail.com X-Host-Fingerprint: 209.85.219.54 mail-oa0-f54.google.com Received: from [209.85.219.54] ([209.85.219.54:60141] helo=mail-oa0-f54.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/B1-29088-4F981335 for ; Tue, 25 Mar 2014 08:51:50 -0500 Received: by mail-oa0-f54.google.com with SMTP id n16so590559oag.27 for ; Tue, 25 Mar 2014 06:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=oyMoD5aXzJv7mCi3Kxvx8LOssWCw7D1QINt7mAtvJdM=; b=d5vHLZCJBp+8wIrImyJyQAvzQgkRQB+CHw9Eo1COPXbFBs4smF1IThMpRRLGGk59Jo AqsJWkW/TIkKM0Md2QzHB3piyiZNazVBsAsPPQ/1Quo/euA8tzHpu2wfexK3E9wrC2Xx nkw0AGolDLnK6MagzpKU4FjywolZ9riraQSUS1s5rAzlcbhY0bVVJ2xvAYZTzdVAuuj0 HvFRQiESBBsZCT+VroOdNvS1g4vYp71muJmWaDF3qJJ0u0nBIQ2lDFktpf97I1eTbthd pHvjV55FzE18FjkJyQSA0GG/DwQIwSFtSVluNE5AlvFPRHrqXw9Rspvfe2UPVNBT6aFJ KHmQ== MIME-Version: 1.0 X-Received: by 10.60.51.69 with SMTP id i5mr3063777oeo.17.1395755505831; Tue, 25 Mar 2014 06:51:45 -0700 (PDT) Received: by 10.76.77.8 with HTTP; Tue, 25 Mar 2014 06:51:45 -0700 (PDT) In-Reply-To: References: <532A3E88.20202@sugarcrm.com> <532A418A.8020607@sugarcrm.com> <532B4A1B.5090503@sugarcrm.com> <532B6581.6030801@sugarcrm.com> <532B91AF.7090804@sugarcrm.com> <5330F929.3080000@sugarcrm.com> <5330FDF7.1040904@sugarcrm.com> Date: Tue, 25 Mar 2014 07:51:45 -0600 Message-ID: To: Tjerk Meesters Cc: Stas Malyshev , Etienne Kneuss , PHP Internals Content-Type: multipart/alternative; boundary=001a11c300de1f10c604f56ea77f Subject: Re: [PHP-DEV] Merge PR 621 From: morrison.levi@gmail.com (Levi Morrison) --001a11c300de1f10c604f56ea77f Content-Type: text/plain; charset=ISO-8859-1 In a similar vein have we checked `offsetSet`? It seems `offsetSet` is not called with `+=`; I am not sure if this is intended; see https://bugs.php.net/bug.php?id=66641 On Tue, Mar 25, 2014 at 4:38 AM, Tjerk Meesters wrote: > Hi, > > > On Tue, Mar 25, 2014 at 11:54 AM, Stas Malyshev >wrote: > > > Hi! > > > > > It's my understanding that you should (have to) only call "get" if you > > > know that the offset exists. > > > > Yes, you are right. I'd still add some example that changes the keys to > > the tests to ensure all cases are covered properly. But looks like it > > works OK in all cases I could think of. > > > > I've updated the test case with such an example. > > PHP-5.6 and master have been updated. > > > > > -- > > Stanislav Malyshev, Software Architect > > SugarCRM: http://www.sugarcrm.com/ > > (408)454-6900 ext. 227 > > > > > > -- > -- > Tjerk > --001a11c300de1f10c604f56ea77f--