Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73421
Return-Path: <tjerk.meesters@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 23533 invoked from network); 25 Mar 2014 10:38:51 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 25 Mar 2014 10:38:51 -0000
Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.176 as permitted sender)
X-PHP-List-Original-Sender: tjerk.meesters@gmail.com
X-Host-Fingerprint: 209.85.128.176 mail-ve0-f176.google.com  
Received: from [209.85.128.176] ([209.85.128.176:53272] helo=mail-ve0-f176.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 28/70-20971-8BC51335 for <internals@lists.php.net>; Tue, 25 Mar 2014 05:38:49 -0500
Received: by mail-ve0-f176.google.com with SMTP id cz12so277059veb.7
        for <internals@lists.php.net>; Tue, 25 Mar 2014 03:38:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=sz4el1GxGGq1CZLFsyk5ntxfH5dkYXnVA6tWmYxxbjM=;
        b=Gl3LoXXHV3OF37qbS4YsW+F/noJUwSicsAWyn7wOBwx24FyhAc4WUcJSLB3jl5ypj5
         LQ4Htb5qI9Ss4p1OvBgdsb/LRM4vqxRAhiKl/h5nN+pxnhjUIk5BSo3HcvTsvQkPPHDa
         PXKxhUBJJZVXUlqFpkAt/vOH2udpvO+NUG0TxR4huTQgBXr9aSHQtFn0JM1abEZiuWap
         HZ1vzFeDk9N0ljQbw+6zzKJKy/KGho3n+vHchck3qkKEeGcBAZ1Znj1AAnVRfpuaINV6
         9JgHsNe10Ck9k1QQK93MBGbhhVrHhtXaL0orKYAro8t4/jZ1RsbPgdnx8K1dyLGnwLZD
         DhQg==
MIME-Version: 1.0
X-Received: by 10.52.99.168 with SMTP id er8mr4756791vdb.26.1395743925410;
 Tue, 25 Mar 2014 03:38:45 -0700 (PDT)
Received: by 10.58.55.131 with HTTP; Tue, 25 Mar 2014 03:38:45 -0700 (PDT)
In-Reply-To: <5330FDF7.1040904@sugarcrm.com>
References: <CAHMUw2EeYA3m4QnRtLYm1PRa3taGiS8Sx5GxdN==ZYTQoFV=vQ@mail.gmail.com>
	<532A3E88.20202@sugarcrm.com>
	<ECAD39ED-2A1D-4B54-80D5-4CB4FBA71364@gmail.com>
	<532A418A.8020607@sugarcrm.com>
	<CACQesk74e3=FNd4KgC4XDHXiq97yk8KXRXAvV3tqRWOzFwN_pw@mail.gmail.com>
	<532B4A1B.5090503@sugarcrm.com>
	<CACQesk5W8H+NuZVeUprDOMK26szTQYtHFeT5XoWwYXLCb-8=Vw@mail.gmail.com>
	<532B6581.6030801@sugarcrm.com>
	<CAHMUw2Ff0cQjudC0tdJ+6y8ybsuFQ9qN6kdZ0kbKbfAcQG3jWA@mail.gmail.com>
	<532B91AF.7090804@sugarcrm.com>
	<CAHMUw2EJMPsAuW2W1J3OWb05yAa1iXfzP5ebJxkKzO1Skj+DVg@mail.gmail.com>
	<CAHMUw2FNswaNZ50jjGHu__=pBcZp+ZV2OK69u6D-xODzvgpMsw@mail.gmail.com>
	<5330F929.3080000@sugarcrm.com>
	<CAHMUw2GFkGCJeLAet3e-NoYevchD3ab4SvTc4Gd6GD7uceakXw@mail.gmail.com>
	<5330FDF7.1040904@sugarcrm.com>
Date: Tue, 25 Mar 2014 18:38:45 +0800
Message-ID: <CAHMUw2F4CGwxzkUuvuDs-oGbC10Rr2cJOBOwnL=mJQ8b_TWtHg@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Etienne Kneuss <colder@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf3071cab0df22f304f56bf412
Subject: Re: [PHP-DEV] Merge PR 621
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--20cf3071cab0df22f304f56bf412
Content-Type: text/plain; charset=ISO-8859-1

Hi,


On Tue, Mar 25, 2014 at 11:54 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> > It's my understanding that you should (have to) only call "get" if you
> > know that the offset exists.
>
> Yes, you are right. I'd still add some example that changes the keys to
> the tests to ensure all cases are covered properly. But looks like it
> works OK in all cases I could think of.
>

I've updated the test case with such an example.

PHP-5.6 and master have been updated.



> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>



-- 
--
Tjerk

--20cf3071cab0df22f304f56bf412--