Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73410 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92550 invoked from network); 25 Mar 2014 03:54:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Mar 2014 03:54:44 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.115 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.115 smtp115.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.115] ([108.166.43.115:39515] helo=smtp115.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B9/71-19971-30EF0335 for ; Mon, 24 Mar 2014 22:54:44 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp7.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 667C01B912F; Mon, 24 Mar 2014 23:54:41 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp7.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id F39E11B9093; Mon, 24 Mar 2014 23:54:40 -0400 (EDT) Message-ID: <5330FDF7.1040904@sugarcrm.com> Date: Mon, 24 Mar 2014 20:54:31 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Tjerk Meesters CC: Etienne Kneuss , PHP Internals References: <532A3E88.20202@sugarcrm.com> <532A418A.8020607@sugarcrm.com> <532B4A1B.5090503@sugarcrm.com> <532B6581.6030801@sugarcrm.com> <532B91AF.7090804@sugarcrm.com> <5330F929.3080000@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Merge PR 621 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > It's my understanding that you should (have to) only call "get" if you > know that the offset exists. Yes, you are right. I'd still add some example that changes the keys to the tests to ensure all cases are covered properly. But looks like it works OK in all cases I could think of. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227