Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73409
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5330F929.3080000@sugarcrm.com>
References: <CAHMUw2EeYA3m4QnRtLYm1PRa3taGiS8Sx5GxdN==ZYTQoFV=vQ@mail.gmail.com>
	<532A3E88.20202@sugarcrm.com>
	<ECAD39ED-2A1D-4B54-80D5-4CB4FBA71364@gmail.com>
	<532A418A.8020607@sugarcrm.com>
	<CACQesk74e3=FNd4KgC4XDHXiq97yk8KXRXAvV3tqRWOzFwN_pw@mail.gmail.com>
	<532B4A1B.5090503@sugarcrm.com>
	<CACQesk5W8H+NuZVeUprDOMK26szTQYtHFeT5XoWwYXLCb-8=Vw@mail.gmail.com>
	<532B6581.6030801@sugarcrm.com>
	<CAHMUw2Ff0cQjudC0tdJ+6y8ybsuFQ9qN6kdZ0kbKbfAcQG3jWA@mail.gmail.com>
	<532B91AF.7090804@sugarcrm.com>
	<CAHMUw2EJMPsAuW2W1J3OWb05yAa1iXfzP5ebJxkKzO1Skj+DVg@mail.gmail.com>
	<CAHMUw2FNswaNZ50jjGHu__=pBcZp+ZV2OK69u6D-xODzvgpMsw@mail.gmail.com>
	<5330F929.3080000@sugarcrm.com>
Date: Tue, 25 Mar 2014 11:45:23 +0800
Message-ID: <CAHMUw2GFkGCJeLAet3e-NoYevchD3ab4SvTc4Gd6GD7uceakXw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Etienne Kneuss <colder@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1135f378901b7104f5662ed0
Subject: Re: [PHP-DEV] Merge PR 621
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--001a1135f378901b7104f5662ed0
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Mar 25, 2014 at 11:34 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> > Do you have any issues with the code as it stands now?
> >
> > https://github.com/php/php-src/pull/614
>
> Something I don't understand in this patch: so if we don't have "has"
> override, we'd get value == NULL and then we go and check internal
> hashtable. Shouldn't we first check the get override and ask it with
> BP_VAR_IS, and only if get override is not there use direct hash access?
>

It's my understanding that you should (have to) only call "get" if you know
that the offset exists.


>
> E.g. imagine this:
>
> class SecretArrayObject extends ArrayObject
> {
>         public function offsetGet($offset) {
>                 var_dump('Called: '.__METHOD__);
>                 return parent::offsetGet(str_rot13($offset));
>         }
>         public function offsetSet($offset) {
>                 var_dump('Called: '.__METHOD__);
>                 return parent::offsetSet(str_rot13($offset));
>         }
> }
>
> I think on this example your code may fail to go to correct items when
> doing isset/isempty, since if I ask for 'qux' it would actually check
> the value I've put there for 'dhk'.
>

This particular class should override `offsetExists($offset)` as well, i.e.:

    public function offsetExists($offset)
    {
        return parent::offsetExists(str_rot13($offset));
    }


> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>



-- 
--
Tjerk

--001a1135f378901b7104f5662ed0--